netdev - Re: [PATCH] chcr_ktls: fix a possible null-pointer dereference in chcr_ktls_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55a08c90-df62-41cd-8ab9-89dc8199fbfb@web.de>
Date: Fri, 8 Nov 2024 16:00:22 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Tuo Li <islituo@...il.com>, netdev@...r.kernel.org,
 Andrew Lunn <andrew@...n.ch>, Ayush Sawal <ayush.sawal@...lsio.com>,
 "David S. Miller" <davem@...emloft.net>, Dragos Tatulea
 <dtatulea@...dia.com>, Eric Dumazet <edumazet@...gle.com>,
 Jacob Keller <jacob.e.keller@...el.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Mina Almasry <almasrymina@...gle.com>,
 Simon Horman <horms@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Jia-Ju Bai <baijiaju1990@...il.com>
Subject: Re: [PATCH] chcr_ktls: fix a possible null-pointer dereference in
 chcr_ktls_dev_add()

…
> Consider the following execution scenario:
>
>   chcr_ktls_cpl_act_open_rpl()   //641
>     u_ctx = adap->uld[CXGB4_ULD_KTLS].handle;   //686
>     if (u_ctx) {  //687
>     complete(&tx_info->completion);  //704
>
> The variable u_ctx is checked by an if statement at Line 687, which means
> it can be NULL. Then, complete() is called at Line 704, which will wake
> up wait_for_completion_xxx().
…

To which software revision would you like to refer here?

How does the presented information fit to a statement like the following?
https://elixir.bootlin.com/linux/v6.12-rc6/source/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c#L442

	if (u_ctx && u_ctx->detach)
		goto out;

Would you eventually like to trace the control flow back any further
for the data structure member “handle”?

Regards,
Markus