netdev - Re: [PATCH v5 05/17] wifi: cc33xx: Add cmd.c, cmd.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a707eb5-8695-4f0d-bb08-6de95017d2b1@web.de>
Date: Fri, 8 Nov 2024 17:25:56 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Michael Nemanov <michael.nemanov@...com>, linux-wireless@...r.kernel.org,
 netdev@...r.kernel.org, devicetree@...r.kernel.org,
 Conor Dooley <conor+dt@...nel.org>, "David S. Miller" <davem@...emloft.net>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Jakub Kicinski <kuba@...nel.org>,
 Kalle Valo <kvalo@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Sabeeh Khan <sabeeh-khan@...com>,
 Simon Horman <horms@...nel.org>
Subject: Re: [PATCH v5 05/17] wifi: cc33xx: Add cmd.c, cmd.h

…
> Similar to wlcore, all commands eventually reach
> __cc33xx_cmd_send which fills a generic command
> header and send the buffer via the IO abstraction layer.
…

You may occasionally put more than 56 characters into text lines
for an improved change description.

…
> +++ b/drivers/net/wireless/ti/cc33xx/cmd.c
> @@ -0,0 +1,1920 @@
…
> +int cc33xx_set_link(struct cc33xx *cc, struct cc33xx_vif *wlvif, u8 link)
> +{
> +	unsigned long flags;
> +
> +	/* these bits are used by op_tx */
> +	spin_lock_irqsave(&cc->cc_lock, flags);
> +	__set_bit(link, cc->links_map);
> +	__set_bit(link, wlvif->links_map);
> +	spin_unlock_irqrestore(&cc->cc_lock, flags);
…

Under which circumstances would you become interested to apply a macro call
like “scoped_guard(spinlock_irqsave, &cc->cc_lock)”?
https://elixir.bootlin.com/linux/v6.12-rc6/source/include/linux/spinlock.h#L572

Regards,
Markus