netdev - Re: [PATCH net-next 1/5] net: phylink: move manual flow control setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a31b965a-c9cd-4695-a7f1-9201a00e2dd4@lunn.ch>
Date: Fri, 8 Nov 2024 18:34:04 +0100
From: Andrew Lunn <andrew@...n.ch>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/5] net: phylink: move manual flow control
 setting

On Fri, Nov 08, 2024 at 04:01:44PM +0000, Russell King (Oracle) wrote:
> Move the handling of manual flow control configuration to a common
> location during resolve. We currently evaluate this for all but
> fixed links.

I could be mis-remembering, but i thought somebody recently mentioned
they wanted manual control for flow control for fixed links.

Nothing comes to mind why it should not work. With manual control, it
is purely a MAC problem. There is no negotiation involved which would
require a PHY, which is missing in the case of fixed links.

Am i missing something? Other than you want to keep the current
behaviour.

	Andrew