netdev - Re: [PATCH net-next v2] eth: fbnic: Add PCIe hardware statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAG4C-OmPAqNe2RHwgBZ9+1MBq48bOOLgDdFnPiRyPz6Duy15nQ@mail.gmail.com>
Date: Fri, 8 Nov 2024 14:37:26 -0800
From: Sanman Pradhan <sanman.p211993@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, alexanderduyck@...com, kernel-team@...a.com, 
	davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, horms@...nel.org, 
	corbet@....net, mohsin.bashr@...il.com, sanmanpradhan@...a.com, 
	andrew+netdev@...n.ch, vadim.fedorenko@...ux.dev, jdamato@...tly.com, 
	sdf@...ichev.me, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] eth: fbnic: Add PCIe hardware statistics

On Thu, 7 Nov 2024 at 10:20, Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed,  6 Nov 2024 18:05:55 -0800 Sanman Pradhan wrote:
> > +     FBNIC_HW_STAT("pcie_ob_rd_tlp", pcie.ob_rd_tlp),
> > +     FBNIC_HW_STAT("pcie_ob_rd_dword", pcie.ob_rd_dword),
> > +     FBNIC_HW_STAT("pcie_ob_wr_tlp", pcie.ob_wr_tlp),
> > +     FBNIC_HW_STAT("pcie_ob_wr_dword", pcie.ob_wr_dword),
> > +     FBNIC_HW_STAT("pcie_ob_cpl_tlp", pcie.ob_cpl_tlp),
> > +     FBNIC_HW_STAT("pcie_ob_cpl_dword", pcie.ob_cpl_dword),
> > +     FBNIC_HW_STAT("pcie_ob_rd_no_tag", pcie.ob_rd_no_tag),
> > +     FBNIC_HW_STAT("pcie_ob_rd_no_cpl_cred", pcie.ob_rd_no_cpl_cred),
> > +     FBNIC_HW_STAT("pcie_ob_rd_no_np_cred", pcie.ob_rd_no_np_cred),
>
> Having thought about this a bit longer I think Andrew's point is valid.
> Let's move these to a debugfs file. Sorry for the flip flop.

Thanks for the review, I have submitted v3 with the necessary changes.