netdev - Re: [PATCH 1/3] dt-bindings: net: nuvoton: Add schema for Nuvoton MA35 family GMAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7a476087-9efc-4271-bd2c-d04a0c1d0dff@gmail.com>
Date: Fri, 8 Nov 2024 11:24:04 +0800
From: Joey Lu <a0987203069@...il.com>
To: Conor Dooley <conor@...nel.org>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, mcoquelin.stm32@...il.com, richardcochran@...il.com,
 alexandre.torgue@...s.st.com, joabreu@...opsys.com, ychuang3@...oton.com,
 schung@...oton.com, yclu4@...oton.com, linux-arm-kernel@...ts.infradead.org,
 netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, openbmc@...ts.ozlabs.org,
 linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH 1/3] dt-bindings: net: nuvoton: Add schema for Nuvoton
 MA35 family GMAC


Conor Dooley 於 11/8/2024 1:09 AM 寫道:
> On Thu, Nov 07, 2024 at 06:15:51PM +0800, Joey Lu wrote:
>> Conor Dooley 於 11/6/2024 11:44 PM 寫道:
>>> On Wed, Nov 06, 2024 at 07:19:28PM +0800, Joey Lu wrote:
>>>> +  nuvoton,sys:
>>>> +    $ref: /schemas/types.yaml#/definitions/phandle
>>>> +    description: phandle to access GCR (Global Control Register) registers.
>>> Why do you need a phandle to this? You appear to have multiple dwmacs on
>>> your device if the example is anything to go by, how come you don't need
>>> to access different portions of this depending on which dwmac instance
>>> you are?
>> On our platform, a system register is required to specify the TX/RX clock
>> path delay control, switch modes between RMII and RGMII, and configure other
>> related settings.
>>>> +  resets:
>>>> +    maxItems: 1
>>>> +
>>>> +  reset-names:
>>>> +    items:
>>>> +      - const: stmmaceth
>>>> +
>>>> +  mac-id:
>>>> +    maxItems: 1
>>>> +    description:
>>>> +      The interface of MAC.
>>> A vendor prefix is required for custom properties, but I don't think you
>>> need this and actually it is a bandaid for some other information you're
>>> missing. Probably related to your nuvoton,sys property only being a
>>> phandle with no arguments.
>> This property will be removed.
> I'm almost certain you can't just remove this property, because you need
> it to tell which portion of the GCR is applicable to the dwmac instance
> in question. Instead, you need to ad an argument to your phandle. The
> starfive dwmac binding/driver has an example of what you can do.

Yes, I will use this method instead.🙂

mac-id and tx/rx-delay will be arguments of syscon.

Thanks!