netdev - Re: [PATCH net-next v2] bnxt_en: add unlocked version of bnxt_refclk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALs4sv1RA2AOOXtNRVpNQLCsjmw3zSnq+ZPm8rmEo3pV+aDQpQ@mail.gmail.com>
Date: Fri, 8 Nov 2024 10:18:08 +0530
From: Pavan Chebbi <pavan.chebbi@...adcom.com>
To: Vadim Fedorenko <vadfed@...a.com>
Cc: Vadim Fedorenko <vadim.fedorenko@...ux.dev>, Michael Chan <michael.chan@...adcom.com>, 
	Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>, Paolo Abeni <pabeni@...hat.com>, 
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, 
	Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH net-next v2] bnxt_en: add unlocked version of bnxt_refclk_read

On Fri, Nov 8, 2024 at 3:19 AM Vadim Fedorenko <vadfed@...a.com> wrote:
>
> Serialization of PHC read with FW reset mechanism uses ptp_lock which
> also protects timecounter updates. This means we cannot grab it when
> called from bnxt_cc_read(). Let's move locking into different function.
>
> Fixes: 6c0828d00f07 ("bnxt_en: replace PTP spinlock with seqlock")
> Signed-off-by: Vadim Fedorenko <vadfed@...a.com>
> ---
> v1 -> v2:
> * add lock around timecounter_init() in bnxt_ptp_timecounter_init()
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c | 35 +++++++++++++------
>  1 file changed, 24 insertions(+), 11 deletions(-)
>
Thanks Vadim.
Reviewed-by: Pavan Chebbi <pavan.chebbi@...adcom.com>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)