netdev - Re: [PATCH net] net/smc: Fix lookup of netdev by using ib_device_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKYAXd8csLBOYhUOOXWnVDZjiH03KHdwuL68aQKAtF9dFW=YfA@mail.gmail.com>
Date: Sat, 9 Nov 2024 14:32:07 +0900
From: Namjae Jeon <linkinjeon@...nel.org>
To: Leon Romanovsky <leon@...nel.org>
Cc: Halil Pasic <pasic@...ux.ibm.com>, Wenjia Zhang <wenjia@...ux.ibm.com>, 
	Wen Gu <guwen@...ux.alibaba.com>, "D. Wythe" <alibuda@...ux.alibaba.com>, 
	Tony Lu <tonylu@...ux.alibaba.com>, David Miller <davem@...emloft.net>, 
	Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, 
	netdev@...r.kernel.org, linux-rdma@...r.kernel.org, 
	linux-s390@...r.kernel.org, Heiko Carstens <hca@...ux.ibm.com>, 
	Jan Karcher <jaka@...ux.ibm.com>, Gerd Bayer <gbayer@...ux.ibm.com>, 
	Alexandra Winter <wintera@...ux.ibm.com>, Nils Hoppmann <niho@...ux.ibm.com>, 
	Niklas Schnell <schnelle@...ux.ibm.com>, Thorsten Winkler <twinkler@...ux.ibm.com>, 
	Karsten Graul <kgraul@...ux.ibm.com>, Stefan Raspl <raspl@...ux.ibm.com>, 
	Aswin K <aswin@...ux.ibm.com>, linux-cifs@...r.kernel.org, 
	Kangjing Huang <huangkangjing@...il.com>
Subject: Re: [PATCH net] net/smc: Fix lookup of netdev by using ib_device_get_netdev()

On Sat, Nov 9, 2024 at 2:59 AM Leon Romanovsky <leon@...nel.org> wrote:
>
> On Fri, Nov 08, 2024 at 08:40:40AM +0900, Namjae Jeon wrote:
> > On Thu, Nov 7, 2024 at 9:00 PM Halil Pasic <pasic@...ux.ibm.com> wrote:
> > >
> > > On Wed, 6 Nov 2024 15:59:10 +0200
> > > Leon Romanovsky <leon@...nel.org> wrote:
> > >
> > > > > Does  fs/smb/server/transport_rdma.c qualify as inside of RDMA core code?
> > > >
> > > > RDMA core code is drivers/infiniband/core/*.
> > >
> > > Understood. So this is a violation of the no direct access to the
> > > callbacks rule.
> > >
> > > >
> > > > > I would guess it is not, and I would not actually mind sending a patch
> > > > > but I have trouble figuring out the logic behind  commit ecce70cf17d9
> > > > > ("ksmbd: fix missing RDMA-capable flag for IPoIB device in
> > > > > ksmbd_rdma_capable_netdev()").
> > > >
> > > > It is strange version of RDMA-CM. All other ULPs use RDMA-CM to avoid
> > > > GID, netdev and fabric complexity.
> > >
> > > I'm not familiar enough with either of the subsystems. Based on your
> > > answer my guess is that it ain't outright bugous but still a layering
> > > violation. Copying linux-cifs@...r.kernel.org so that
> > > the smb are aware.
> > Could you please elaborate what the violation is ?
>
> There are many, but the most screaming is that ksmbd has logic to
> differentiate IPoIB devices. These devices are pure netdev devices
> and should be treated like that. ULPs should treat them exactly
> as they treat netdev devices.
Okay, I'll discuss with Kangjing if there's another way to avoid this issue.
If not, I'll revert the patch.

Thanks.
>
> > I would also appreciate it if you could suggest to me how to fix this.
> >
> > Thanks.
> > >
> > > Thank you very much for all the explanations!
> > >
> > > Regards,
> > > Halil
> > >