netdev - Re: [PATCH net v6] net: sched: cls_u32: Fix u32's systematic failure to free IDR entries for hnodes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c74d0c92-7e93-4f96-bf24-ab0ca95f1188@orange.com>
Date: Sat, 9 Nov 2024 16:39:03 +0100
From: Alexandre Ferrieux <alexandre.ferrieux@...il.com>
To: Jamal Hadi Salim <jhs@...atatu.com>,
 Alexandre Ferrieux <alexandre.ferrieux@...il.com>
Cc: Eric Dumazet <edumazet@...gle.com>, Cong Wang <xiyou.wangcong@...il.com>,
 Jiri Pirko <jiri@...nulli.us>,
 Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH net v6] net: sched: cls_u32: Fix u32's systematic failure
 to free IDR entries for hnodes.

On 09/11/2024 13:50, Jamal Hadi Salim wrote:
> On Fri, Nov 8, 2024 at 9:12 AM Alexandre Ferrieux
> <alexandre.ferrieux@...il.com> wrote:
>>
>> This patch adds the missing decoding logic for handles that
>> deserve it, along with a corresponding tdc test.
>>
>> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
>> Reviewed-by: Eric Dumazet <edumazet@...gle.com>
>> Signed-off-by: Alexandre Ferrieux <alexandre.ferrieux@...nge.com>
> 
> 
> Ok, looks good.
> Please split the test into a separate patch targeting net-next.

I'm unfamiliar with the net/net-next dance (beyond the dichotomy between fixes
and new features). Can you please explain why the test should not be in the same
commit ?

> Also your "Fixes" should be:> commit e7614370d6f04711c4e4b48f7055e5008fa4ed42

Ah OK, I see, that's the IDR conversion. I had mistakenly believed it was an
isofunctional change, and upon seeing the "(|0x800)<<20" without "(>>20)&0x7FF"
in the initial commit, I believed it was a 19-year old bug. Then it's only a
7-year-old, thanks a lot for the correction.

> When you send the next version please include my Acked-by:

Will do. Thanks a lot !