netdev - Re: [PATCH net-next v2] net: dlink: add support for reporting stats via `ethtool -S`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAjsZQwhDeFEK2qEwy6b4-GbDUymiOz5xzrYwmMSTe-Jf_3oKQ@mail.gmail.com>
Date: Sun, 10 Nov 2024 23:25:44 +0900
From: Moon Yeounsu <yyyynoom@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, andrew@...n.ch
Subject: Re: [PATCH net-next v2] net: dlink: add support for reporting stats
 via `ethtool -S`

First of all, I would like to extend my apologies.
In the previous patch, the `get_ethtool_rmon_stats()` function should
have called the `get_stats()` function to update the stats
information,
but I missed this. I will include this part in the next patch.

On Fri, Nov 8, 2024 at 1:09 PM Jakub Kicinski <kuba@...nel.org> wrote:
> Do these macro wrappers really buy you anything?
> They make the code a lot harder to follow :(
I fully understand that these macros can be difficult to comprehend at
first glance.
However, I wanted to avoid code duplication with this structure.
For now, I will write the code in a way that minimizes the use of
macros as much as possible.

> nit: multiple empty lines, checkpatch --strict should catch this
In the next patch, I will use the `checkpatch --strict` option to fix
as many warnings and checks as possible before submitting the patch.
I also confirmed from patchwork[1] that there were additional warning messages.
I will pay attention to and correct these warnings in the next patch.
Thank you for pointing that out.

> We've been getting conversion patches replacing such code with
> ethtool_puts() lately, let's use it from the start.
I will do so.

[1]: https://patchwork.kernel.org/project/netdevbpf/patch/20241107151929.37147-5-yyyynoom@gmail.com/