netdev - Re: [PATCH net v7] net: sched: cls_u32: Fix u32's systematic failure to free IDR entries for hnodes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b5df8fb4-e093-4798-8644-fd0604d0d7fe@mojatatu.com>
Date: Sun, 10 Nov 2024 15:14:08 -0300
From: Victor Nogueira <victor@...atatu.com>
To: Alexandre Ferrieux <alexandre.ferrieux@...il.com>, edumazet@...gle.com
Cc: jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
 horms@...nel.org, alexandre.ferrieux@...nge.com, netdev@...r.kernel.org
Subject: Re: [PATCH net v7] net: sched: cls_u32: Fix u32's systematic failure
 to free IDR entries for hnodes.

On 10/11/2024 14:28, Alexandre Ferrieux wrote:
> To generate hnode handles (in gen_new_htid()), u32 uses IDR and
> encodes the returned small integer into a structured 32-bit
> word. Unfortunately, at disposal time, the needed decoding
> is not done. As a result, idr_remove() fails, and the IDR
> fills up. Since its size is 2048, the following script ends up
> with "Filter already exists":
> 
>    tc filter add dev myve $FILTER1
>    tc filter add dev myve $FILTER2
>    for i in {1..2048}
>    do
>      echo $i
>      tc filter del dev myve $FILTER2
>      tc filter add dev myve $FILTER2
>    done
> 
> This patch adds the missing decoding logic for handles that
> deserve it.
> 
> Fixes: e7614370d6f0 ("net_sched: use idr to allocate u32 filter handles")
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>
> Acked-by: Jamal Hadi Salim <jhs@...atatu.com>
> Signed-off-by: Alexandre Ferrieux <alexandre.ferrieux@...nge.com>

Tested-by: Victor Nogueira <victor@...atatu.com>