netdev - Re: [PATCH 1/3] dt-bindings: net: nuvoton: Add schema for Nuvoton MA35 family GMAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cb718d0f-75a5-4720-b0c1-d8fb1f1c653b@gmail.com>
Date: Mon, 11 Nov 2024 17:17:51 +0800
From: Joey Lu <a0987203069@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, mcoquelin.stm32@...il.com, richardcochran@...il.com,
 alexandre.torgue@...s.st.com, joabreu@...opsys.com, ychuang3@...oton.com,
 schung@...oton.com, yclu4@...oton.com, linux-arm-kernel@...ts.infradead.org,
 netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, openbmc@...ts.ozlabs.org,
 linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH 1/3] dt-bindings: net: nuvoton: Add schema for Nuvoton
 MA35 family GMAC


On 11/7/24 21:18, Andrew Lunn wrote:
> On Thu, Nov 07, 2024 at 06:31:26PM +0800, Joey Lu wrote:
>> Dear Andrew,
>>
>> Thank you for your reply.
>>
>> Andrew Lunn 於 11/7/2024 2:13 AM 寫道:
>>>> +  phy-mode:
>>>> +    enum:
>>>> +      - rmii
>>>> +      - rgmii-id
>>> The phy-mode deepened on the board design. All four rgmii values are
>>> valid.
>> I will add them.
>>>> +
>>>> +  tx_delay:
>>>> +    maxItems: 1
>>>> +    description:
>>>> +      Control transmit clock path delay in nanoseconds.
>>>> +
>>>> +  rx_delay:
>>>> +    maxItems: 1
>>>> +    description:
>>>> +      Control receive clock path delay in nanoseconds.
>>> If you absolutely really need these, keep them, but i suggest you drop
>>> them. They just cause confusion, when ideally we want the PHY to be
>>> adding RGMII delays, not the MAC.
>>>
>>> If you do need them, then they should be in pS.
>> I will fix it.
>>
>> We have customers who use a fixed link instead of a PHY, so these properties
>> may be necessary.
> That is a legitimate use case which can require the MAC to add delays,
> but i generally try to get the switch on the other end to add the
> delays, just to keep with the uniform setup.
>
> Also, please take a look at ethernet-controller.yaml, these should be
> called rx-internal-delay-ps & tx-internal-delay-ps.
>
> 	Andrew

Thank you, sir. I will use rx-internal-delay-ps and tx-internal-delay-ps 
instead.

                 Joey