netdev - Re: [PATCHv2 net-next] net: modernize ioremap in probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241112-snobbish-cocky-hyena-d0834a-mkl@pengutronix.de>
Date: Tue, 12 Nov 2024 08:48:43 +0100
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Rosen Penev <rosenp@...il.com>
Cc: netdev@...r.kernel.org, 
	Chandrasekar Ramakrishnan <rcsekar@...sung.com>, Vincent Mailhol <mailhol.vincent@...adoo.fr>, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Kurt Kanzenbach <kurt@...utronix.de>, 
	Vladimir Oltean <olteanv@...il.com>, Chris Snook <chris.snook@...il.com>, 
	Marcin Wojtas <marcin.s.wojtas@...il.com>, Russell King <linux@...linux.org.uk>, 
	Horatiu Vultur <horatiu.vultur@...rochip.com>, 
	"maintainer:MICROCHIP LAN966X ETHERNET DRIVER" <UNGLinuxDriver@...rochip.com>, Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>, 
	Niklas Söderlund <niklas.soderlund@...natech.se>, Doug Berger <opendmb@...il.com>, 
	Florian Fainelli <florian.fainelli@...adcom.com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Heiner Kallweit <hkallweit1@...il.com>, 
	Richard Cochran <richardcochran@...il.com>, "open list:MCAN MMIO DEVICE DRIVER" <linux-can@...r.kernel.org>, 
	open list <linux-kernel@...r.kernel.org>, 
	"open list:RENESAS ETHERNET SWITCH DRIVER" <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCHv2 net-next] net: modernize ioremap in probe

On 11.11.2024 12:02:12, Rosen Penev wrote:
> I changed resource acquisition to be performed in a single step. Possible
> because devm is used here.

You should describe in an imperative way your changes. Something like:

Resource acquisition can be performed in a single step.

Replace platform_get_resource_byname() + devm_ioremap() by
devm_platform_ioremap_resource_byname().

...and list the other changes, too.

> Signed-off-by: Rosen Penev <rosenp@...il.com>
> ---
>  v2: fixed compilation errors on PPC and reworded commit message
>  drivers/net/can/m_can/m_can_platform.c        | 13 +++-------
>  drivers/net/can/sja1000/sja1000_platform.c    | 15 +++--------

Reviewed-by: Marc Kleine-Budde <mkl@...gutronix.de> # for CAN

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)