netdev - Re: [PATCH ipsec-next v2 0/4] xfrm: Convert __xfrm4_dst_lookup() and its callers to dscp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZzMLHKLEKelIf3f8@gauss3.secunet.de>
Date: Tue, 12 Nov 2024 09:00:28 +0100
From: Steffen Klassert <steffen.klassert@...unet.com>
To: Guillaume Nault <gnault@...hat.com>
CC: Herbert Xu <herbert@...dor.apana.org.au>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, <netdev@...r.kernel.org>,
	Simon Horman <horms@...nel.org>, David Ahern <dsahern@...nel.org>, "Ido
 Schimmel" <idosch@...dia.com>, Eyal Birger <eyal.birger@...il.com>
Subject: Re: [PATCH ipsec-next v2 0/4] xfrm: Convert __xfrm4_dst_lookup() and
 its callers to dscp_t.

On Thu, Oct 31, 2024 at 04:52:27PM +0100, Guillaume Nault wrote:
> This patch series continues to prepare users of ->flowi4_tos to a
> future conversion of this field (__u8 to dscp_t). This time, we convert
> __xfrm4_dst_lookup() and its call chain.
> 
> The objective is to eventually make all users of ->flowi4_tos use a
> dscp_t value. Making ->flowi4_tos a dscp_t field will help avoiding
> regressions where ECN bits are erroneously interpreted as DSCP bits.
> 
> Changes since v1:
>   * Rebase on top of ipsec-next. Now we don't convert the ->dst_lookup()
>     callback handlers since they they don't have any "tos" parameter
>     anymore. Therefore, the original patches 4, 5 and 6 are dropped and
>     replaced with the new patch 4, which just converts the "tos" field
>     in struct xfrm_dst_lookup_params.
> 
> Guillaume Nault (4):
>   xfrm: Convert xfrm_get_tos() to dscp_t.
>   xfrm: Convert xfrm_bundle_create() to dscp_t.
>   xfrm: Convert xfrm_dst_lookup() to dscp_t.
>   xfrm: Convert struct xfrm_dst_lookup_params -> tos to dscp_t.
> 
>  include/net/xfrm.h      |  3 ++-
>  net/ipv4/xfrm4_policy.c |  3 ++-
>  net/xfrm/xfrm_policy.c  | 16 ++++++++--------
>  3 files changed, 12 insertions(+), 10 deletions(-)

Series applied to ipsec-next, thanks a lot!