netdev - Re: [PATCH] mac802154: fix interface deletion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6f5d9c1c-cc13-47fa-871d-156f33d595a5@yandex.ru>
Date: Tue, 12 Nov 2024 12:11:16 +0300
From: Dmitry Antipov <dmantipov@...dex.ru>
To: Miquel Raynal <miquel.raynal@...tlin.com>
Cc: Alexander Aring <alex.aring@...il.com>,
 Stefan Schmidt <stefan@...enfreihafen.org>, linux-wpan@...r.kernel.org,
 netdev@...r.kernel.org, lvc-project@...uxtesting.org,
 syzbot+985f827280dc3a6e7e92@...kaller.appspotmail.com
Subject: Re: [PATCH] mac802154: fix interface deletion

On 11/11/24 10:41 PM, Miquel Raynal wrote:

> Why not just enclose this list_del() within a mutex_lock(iflist_mtx)
> like the others? Would probably make more sense and prevent the use of
> yet another protection mechanism? Is there anything preventing the use
> of this mutex here?

Moreover, if we manage interfaces list with RCU and device status with
an extra status bit, do we need 'iflist_mtx' at all? I've tried this
in https://syzkaller.appspot.com/text?tag=Patch&x=17b1f4e8580000 and
it looks good.

Dmitry