netdev - RE: [Intel-wired-lan] [PATCH v4 net-next 2/4] igb: Fix passing 0 to ERR_PTR in igb_run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CH3PR11MB8313753319728FD3B9246CC8EA592@CH3PR11MB8313.namprd11.prod.outlook.com>
Date: Tue, 12 Nov 2024 12:26:19 +0000
From: "Rout, ChandanX" <chandanx.rout@...el.com>
To: Yue Haibing <yuehaibing@...wei.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>, "ast@...nel.org"
	<ast@...nel.org>, "daniel@...earbox.net" <daniel@...earbox.net>,
	"hawk@...nel.org" <hawk@...nel.org>, "john.fastabend@...il.com"
	<john.fastabend@...il.com>, "Fijalkowski, Maciej"
	<maciej.fijalkowski@...el.com>, "vedang.patel@...el.com"
	<vedang.patel@...el.com>, "Joseph, Jithu" <jithu.joseph@...el.com>,
	"andre.guedes@...el.com" <andre.guedes@...el.com>, "horms@...nel.org"
	<horms@...nel.org>, "Keller, Jacob E" <jacob.e.keller@...el.com>,
	"sven.auhagen@...eatech.de" <sven.auhagen@...eatech.de>,
	"alexander.h.duyck@...el.com" <alexander.h.duyck@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"Kuruvinakunnel, George" <george.kuruvinakunnel@...el.com>, "Pandey, Atul"
	<atul.pandey@...el.com>, "Nagraj, Shravan" <shravan.nagraj@...el.com>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"bpf@...r.kernel.org" <bpf@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH v4 net-next 2/4] igb: Fix passing 0 to
 ERR_PTR in igb_run_xdp()



>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Yue
>Haibing
>Sent: Saturday, October 26, 2024 9:43 AM
>To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
><przemyslaw.kitszel@...el.com>; davem@...emloft.net;
>edumazet@...gle.com; kuba@...nel.org; pabeni@...hat.com;
>ast@...nel.org; daniel@...earbox.net; hawk@...nel.org;
>john.fastabend@...il.com; Fijalkowski, Maciej
><maciej.fijalkowski@...el.com>; vedang.patel@...el.com; Joseph, Jithu
><jithu.joseph@...el.com>; andre.guedes@...el.com; horms@...nel.org; Keller,
>Jacob E <jacob.e.keller@...el.com>; sven.auhagen@...eatech.de;
>alexander.h.duyck@...el.com
>Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; linux-
>kernel@...r.kernel.org; bpf@...r.kernel.org; yuehaibing@...wei.com
>Subject: [Intel-wired-lan] [PATCH v4 net-next 2/4] igb: Fix passing 0 to ERR_PTR
>in igb_run_xdp()
>
>igb_run_xdp() converts customed xdp action to a negative error code with the
>sk_buff pointer type which be checked with IS_ERR in igb_clean_rx_irq().
>Remove this error pointer handing instead use plain int return value.
>
>Fixes: 9cbc948b5a20 ("igb: add XDP support")
>Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
>Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
>Signed-off-by: Yue Haibing <yuehaibing@...wei.com>
>---
> drivers/net/ethernet/intel/igb/igb_main.c | 22 ++++++++--------------
> 1 file changed, 8 insertions(+), 14 deletions(-)
>

Tested-by: Chandan Kumar Rout <chandanx.rout@...el.com> (A Contingent Worker at Intel)