netdev - Re: [PATCH net-next v5] eth: fbnic: Add PCIe hardware statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d55bf54b-87c0-460f-b06c-b1941f473922@lunn.ch>
Date: Tue, 12 Nov 2024 01:09:42 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Sanman Pradhan <sanman.p211993@...il.com>
Cc: netdev@...r.kernel.org, alexanderduyck@...com, kuba@...nel.org,
	kernel-team@...a.com, davem@...emloft.net, edumazet@...gle.com,
	pabeni@...hat.com, horms@...nel.org, corbet@....net,
	mohsin.bashr@...il.com, sanmanpradhan@...a.com,
	andrew+netdev@...n.ch, vadim.fedorenko@...ux.dev,
	jdamato@...tly.com, sdf@...ichev.me, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v5] eth: fbnic: Add PCIe hardware statistics

> @@ -145,6 +147,8 @@ struct fbnic_dev *fbnic_devlink_alloc(struct pci_dev *pdev)
> 
>  	fbd->mac_addr_boundary = FBNIC_RPC_TCAM_MACDA_DEFAULT_BOUNDARY;
> 
> +	fbnic_dbg_fbd_init(fbd);
> +
>  	return fbd;
>  }

I thought it was odd that you create debugfs files in
fbnic_devlink_alloc(). But when you look at that function, it is
actually badly named, it is a collection of random initialisation, of
which devlink is just one.

I would suggest you call fbnic_dbg_fbd_init() in probe, like any
normal driver would.

	Andrew