netdev - Re: [PATCH net-next v3 1/7] ndo_fdb_add: Add a parameter to report whether notification was sent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cdebfe36-5306-42c1-aa89-c60b168b2c49@blackwall.org>
Date: Tue, 12 Nov 2024 15:56:28 +0200
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Petr Machata <petrm@...dia.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc: Simon Horman <horms@...nel.org>, Ido Schimmel <idosch@...dia.com>,
 Amit Cohen <amcohen@...dia.com>, Vladimir Oltean <vladimir.oltean@....com>,
 Andy Roulin <aroulin@...dia.com>, mlxsw@...dia.com,
 Przemek Kitszel <przemyslaw.kitszel@...el.com>,
 intel-wired-lan@...ts.osuosl.org, UNGLinuxDriver@...rochip.com,
 Manish Chopra <manishc@...vell.com>, GR-Linux-NIC-Dev@...vell.com,
 Kuniyuki Iwashima <kuniyu@...zon.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 bridge@...ts.linux.dev
Subject: Re: [PATCH net-next v3 1/7] ndo_fdb_add: Add a parameter to report
 whether notification was sent

On 11/11/24 19:08, Petr Machata wrote:
> Currently when FDB entries are added to or deleted from a VXLAN netdevice,
> the VXLAN driver emits one notification, including the VXLAN-specific
> attributes. The core however always sends a notification as well, a generic
> one. Thus two notifications are unnecessarily sent for these operations. A
> similar situation comes up with bridge driver, which also emits
> notifications on its own:
> 
>  # ip link add name vx type vxlan id 1000 dstport 4789
>  # bridge monitor fdb &
>  [1] 1981693
>  # bridge fdb add de:ad:be:ef:13:37 dev vx self dst 192.0.2.1
>  de:ad:be:ef:13:37 dev vx dst 192.0.2.1 self permanent
>  de:ad:be:ef:13:37 dev vx self permanent
> 
> In order to prevent this duplicity, add a paremeter to ndo_fdb_add,
> bool *notified. The flag is primed to false, and if the callee sends a
> notification on its own, it sets it to true, thus informing the core that
> it should not generate another notification.
> 
> Signed-off-by: Petr Machata <petrm@...dia.com>
> Reviewed-by: Amit Cohen <amcohen@...dia.com>
> ---
> 
> Notes:
> CC: Simon Horman <horms@...nel.org>
> CC: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> CC: intel-wired-lan@...ts.osuosl.org
> CC: UNGLinuxDriver@...rochip.com
> CC: Manish Chopra <manishc@...vell.com>
> CC: GR-Linux-NIC-Dev@...vell.com
> CC: Kuniyuki Iwashima <kuniyu@...zon.com>
> CC: Andrew Lunn <andrew+netdev@...n.ch>
> CC: Nikolay Aleksandrov <razor@...ckwall.org>
> CC: bridge@...ts.linux.dev
> 
>  drivers/net/ethernet/intel/i40e/i40e_main.c      |  3 ++-
>  drivers/net/ethernet/intel/ice/ice_main.c        |  4 +++-
>  drivers/net/ethernet/intel/igb/igb_main.c        |  2 +-
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c    |  2 +-
>  drivers/net/ethernet/mscc/ocelot_net.c           |  2 +-
>  drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c |  2 +-
>  drivers/net/macvlan.c                            |  2 +-
>  drivers/net/vxlan/vxlan_core.c                   |  5 ++++-
>  include/linux/netdevice.h                        |  5 ++++-
>  net/bridge/br_fdb.c                              | 12 +++++++-----
>  net/bridge/br_private.h                          |  2 +-
>  net/core/rtnetlink.c                             |  9 ++++++---
>  12 files changed, 32 insertions(+), 18 deletions(-)
> 

LGTM,
Reviewed-by: Nikolay Aleksandrov <razor@...ckwall.org>