netdev - Re: [PATCH ethtool-next v2] rxclass: Make output for RSS context action explicit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241112074047.44490c6e@kernel.org>
Date: Tue, 12 Nov 2024 07:40:47 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Daniel Xu <dxu@...uu.xyz>
Cc: ecree.xilinx@...il.com, jdamato@...tly.com, davem@...emloft.net,
 mkubecek@...e.cz, martin.lau@...ux.dev, netdev@...r.kernel.org,
 kernel-team@...a.com
Subject: Re: [PATCH ethtool-next v2] rxclass: Make output for RSS context
 action explicit

On Mon, 11 Nov 2024 12:05:38 -0700 Daniel Xu wrote:
> -	if (fsp->flow_type & FLOW_RSS)
> -		fprintf(stdout, "\tRSS Context ID: %u\n", rss_context);
> -
>  	if (fsp->ring_cookie == RX_CLS_FLOW_DISC) {
>  		fprintf(stdout, "\tAction: Drop\n");
>  	} else if (fsp->ring_cookie == RX_CLS_FLOW_WAKE) {
>  		fprintf(stdout, "\tAction: Wake-on-LAN\n");
> +	} else if (fsp->flow_type & FLOW_RSS) {
> +		u64 queue = ethtool_get_flow_spec_ring(fsp->ring_cookie);
> +
> +		fprintf(stdout, "\tAction: Direct to RSS context id %u", rss_context);

Do you have strong feelings about the change in formatting?
Looking at Ed's comment on the new test made me wonder if the change 
in capitalization is for the better.

Action: Direct to RSS context id 1 (queue base offset: 2)

vs

Action: Direct to RSS Context ID: 1 (queue base offset: 2)

Given "id" is a word (: I like the ID format, the extra colon is
annoying but OTOH if we retain it your regexp in the other patch
would match before and after..

Actually the best formatting IMHO would be to skip the ID altogether:

Action: Direct to RSS Context 1 (queue base offset: 2)

So please respin this, either set the ID to upper case or skip it.
And depending on the decision here respin the test (feel free to
repost before 24h passes, if you do).