netdev - Re: [PATCH net-next v1 2/2] tools/net/ynl: add async notification handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241112071439.5ade3b1d@kernel.org>
Date: Tue, 12 Nov 2024 07:14:39 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Donald Hunter <donald.hunter@...il.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon
 Horman <horms@...nel.org>, Xiao Liang <shaw.leon@...il.com>, Jiri Pirko
 <jiri@...nulli.us>, donald.hunter@...hat.com
Subject: Re: [PATCH net-next v1 2/2] tools/net/ynl: add async notification
 handling

On Tue, 12 Nov 2024 09:16:02 +0000 Donald Hunter wrote:
> >> I don't follow; what are you suggesting I initialise endtime to when
> >> duration is 0 ?  
> >
> > I was suggesting:
> >
> > 	def poll_nft([...], duration=0)
> >
> > 	endtime = time.time() + duration  
> 
> I want it to run forever if a duration is not provided, but here
> endtime == starttime so it would exit immediately.
> 
> I thought the original approach was fairly pythonic - if duration is not
> specified (None) then there would be no endtime (None).

Ah, makes perfect sense in hindsight, I misread the code.