netdev - RE: [PATCH v3 net-next 2/5] net: enetc: add Tx checksum offload for i.MX95 ENETC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <AS8PR04MB88499F4A54EBA4DC75A78DDC96592@AS8PR04MB8849.eurprd04.prod.outlook.com>
Date: Tue, 12 Nov 2024 19:17:19 +0000
From: Claudiu Manoil <claudiu.manoil@....com>
To: Wei Fang <wei.fang@....com>, Vladimir Oltean <vladimir.oltean@....com>,
	Clark Wang <xiaoning.wang@....com>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>, Frank Li
	<frank.li@....com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>
Subject: RE: [PATCH v3 net-next 2/5] net: enetc: add Tx checksum offload for
 i.MX95 ENETC

> -----Original Message-----
> From: Wei Fang <wei.fang@....com>
> Sent: Tuesday, November 12, 2024 11:15 AM
[...]
> Subject: [PATCH v3 net-next 2/5] net: enetc: add Tx checksum offload for
> i.MX95 ENETC
> 
> In addition to supporting Rx checksum offload, i.MX95 ENETC also supports
> Tx checksum offload. The transmit checksum offload is implemented through
> the Tx BD. To support Tx checksum offload, software needs to fill some
> auxiliary information in Tx BD, such as IP version, IP header offset and
> size, whether L4 is UDP or TCP, etc.
> 
> Same as Rx checksum offload, Tx checksum offload capability isn't defined
> in register, so tx_csum bit is added to struct enetc_drvdata to indicate
> whether the device supports Tx checksum offload.
> 
> Signed-off-by: Wei Fang <wei.fang@....com>
> ---
> v2: refine enetc_tx_csum_offload_check().
> v3:
> 1. refine enetc_tx_csum_offload_check() and enetc_skb_is_tcp() through
> skb->csum_offset instead of touching skb->data.
> 2. add enetc_skb_is_ipv6() helper function
> ---

Reviewed-by: Claudiu Manoil <claudiu.manoil@....com>