netdev - RE: [PATCH net-next 1/2] dt-bindings: net: dsa: microchip: Add SGMII port support to KSZ9477 switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DM3PR11MB8736A69126CEF233DDBF43A5EC592@DM3PR11MB8736.namprd11.prod.outlook.com>
Date: Tue, 12 Nov 2024 02:45:37 +0000
From: <Tristram.Ha@...rochip.com>
To: <krzk@...nel.org>
CC: <Woojung.Huh@...rochip.com>, <andrew@...n.ch>, <olteanv@...il.com>,
	<robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <marex@...x.de>, <UNGLinuxDriver@...rochip.com>,
	<devicetree@...r.kernel.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next 1/2] dt-bindings: net: dsa: microchip: Add SGMII
 port support to KSZ9477 switch

> Subject: Re: [PATCH net-next 1/2] dt-bindings: net: dsa: microchip: Add SGMII port
> support to KSZ9477 switch
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content
> is safe
> 
> On Fri, Nov 08, 2024 at 05:56:32PM -0800, Tristram.Ha@...rochip.com wrote:
> > From: Tristram Ha <tristram.ha@...rochip.com>
> >
> > Update the KSZ9477 switch example to use SFP cage for SGMII support.
> 
> Why? That's just an example. Why do we want it? Why no changes to
> bindings? Your commit msg must answer to all these.

As the added SGMII support needs the correct device tree declaration to
activate the SFP code, users may need that to use the port.  However the
driver can operate the port without that code, if the current patch is
accepted.  But if you say it is not necessary then it is better to not
change the file.