netdev - Re: [PATCH 1/2] docs: net: Fix text in eth/intel, mlx5 and switchdev docs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241111190356.0aefe1b9@kernel.org>
Date: Mon, 11 Nov 2024 19:03:56 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Abhinav Saxena <xandfury@...il.com>
Cc: linux-kernel-mentees@...ts.linuxfoundation.org,
 intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-rdma@...r.kernel.org, rds-devel@....oracle.com, Tony Nguyen
 <anthony.l.nguyen@...el.com>, Przemek Kitszel
 <przemyslaw.kitszel@...el.com>, "David S . Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon
 Horman <horms@...nel.org>, Jonathan Corbet <corbet@....net>, Saeed Mahameed
 <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>, Tariq Toukan
 <tariqt@...dia.com>, Allison Henderson <allison.henderson@...cle.com>,
 Russell King <linux@...linux.org.uk>, Dragos Tatulea <dtatulea@...dia.com>,
 Rahul Rameshbabu <rrameshbabu@...dia.com>
Subject: Re: [PATCH 1/2] docs: net: Fix text in eth/intel, mlx5 and
 switchdev docs

On Fri,  8 Nov 2024 13:25:47 -0700 Abhinav Saxena wrote:
> diff --git a/Documentation/networking/switchdev.rst b/Documentation/networking/switchdev.rst
> index f355f0166f1b..df4b4c4a15d5 100644
> --- a/Documentation/networking/switchdev.rst
> +++ b/Documentation/networking/switchdev.rst
> @@ -162,7 +162,7 @@ The switchdev driver can know a particular port's position in the topology by
>  monitoring NETDEV_CHANGEUPPER notifications.  For example, a port moved into a
>  bond will see its upper master change.  If that bond is moved into a bridge,
>  the bond's upper master will change.  And so on.  The driver will track such
> -movements to know what position a port is in in the overall topology by
> +movements to know what position a port is in the overall topology by

Are you sure? The first 'in' is for position, the second for topology.
Equivalent to:

 movements to know in what position a port is in the overall topology by
                   ^^                         ^^

We can rephrase to avoid the double in:

  The driver will track such movements to know the position of a port
  within the overall topology by registering for netdevice events and
  acting on NETDEV_CHANGEUPPER.

>  registering for netdevice events and acting on NETDEV_CHANGEUPPER.
-- 
pw-bot: cr