netdev - Re: [PATCH net-next v2 00/12] Begin upstreaming Homa transport protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXJAmwM8zrkEZPZF4jbo-yatvcm4DOUYYh8C6bctvYX=eS+qA@mail.gmail.com>
Date: Mon, 11 Nov 2024 22:06:59 -0800
From: John Ousterhout <ouster@...stanford.edu>
To: Joe Damato <jdamato@...tly.com>, John Ousterhout <ouster@...stanford.edu>, netdev@...r.kernel.org, 
	linux-api@...r.kernel.org
Subject: Re: [PATCH net-next v2 00/12] Begin upstreaming Homa transport protocol

On Mon, Nov 11, 2024 at 4:15 PM Joe Damato <jdamato@...tly.com> wrote:
>
> Quick note for future versions:
>
> Consider adding a changelog to the cover letter and to the
> individual patches which change from revision to revision to make
> it easier for folks to follow along with what changed.

Oops, sorry for the omission. I'll get this right in v3 and beyond. In
the meantime, here is the changelog for v2:

- Remove sockaddr_in_union declaration from public API in homa.h
- Remove kernel wrapper functions (homa_send, etc.) from homa.h
- Fix many sparse warnings (still more work to do here) and other issues
  uncovered by test robot
- Fix checkpatch.pl issues
- Remove residual code related to unit tests
- Remove references to tt_record from comments
- Make it safe to delete sockets during homa_socktab scans
- Use uintptr_t for portability fo 32-bit platforms
- Use do_div instead of "/" for portability
- Remove homa->busy_usecs and homa->gro_busy_usecs (not needed in
  this stripped down version of Homa)
- Eliminate usage of cpu_khz, use sched_clock instead of get_cycles
- Add missing checks of kmalloc return values
- Remove "inline" qualifier from functions in .c files
- Document that pad fields must be zero
- Use more precise type "uint32_t" rather than "int"
- Remove unneeded #include of linux/version.h

> You can find more information about this here:
> https://www.kernel.org/doc/html/v6.11/process/submitting-patches.html#respond-to-review-comments
>
> And it might be helpful to take a look at other series on the list
> which have multiple revisions [1] to get a sense of how others
> typically do this.
>
> [1]: https://lore.kernel.org/netdev/20241030-feature_ptp_netnext-v19-0-94f8aadc9d5c@bootlin.com/