netdev - Re: [PATCHv3 net-next] net: modernize IRQ resource acquisition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241112172302.582285d3@kernel.org>
Date: Tue, 12 Nov 2024 17:23:02 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Rosen Penev <rosenp@...il.com>
Cc: netdev@...r.kernel.org, Marc Kleine-Budde <mkl@...gutronix.de>, Vincent
 Mailhol <mailhol.vincent@...adoo.fr>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Florian Fainelli
 <florian.fainelli@...adcom.com>, Vladimir Oltean <olteanv@...il.com>,
 Chen-Yu Tsai <wens@...e.org>, Jernej Skrabec <jernej.skrabec@...il.com>,
 Samuel Holland <samuel@...lland.org>, Pantelis Antoniou
 <pantelis.antoniou@...il.com>, Marcin Wojtas <marcin.s.wojtas@...il.com>,
 Byungho An <bh74.an@...sung.com>, Kevin Brace
 <kevinbrace@...cecomputerlab.com>, Francois Romieu <romieu@...zoreil.com>,
 Michal Simek <michal.simek@....com>, Heiner Kallweit
 <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, Zhao Qiang
 <qiang.zhao@....com>, linux-can@...r.kernel.org (open list:CAN NETWORK
 DRIVERS), linux-kernel@...r.kernel.org (open list),
 linux-arm-kernel@...ts.infradead.org (moderated list:ARM/Allwinner sunXi
 SoC support), linux-sunxi@...ts.linux.dev (open list:ARM/Allwinner sunXi
 SoC support), linuxppc-dev@...ts.ozlabs.org (open list:FREESCALE SOC
 FS_ENET DRIVER)
Subject: Re: [PATCHv3 net-next] net: modernize IRQ resource acquisition

On Tue, 12 Nov 2024 13:14:42 -0800 Rosen Penev wrote:
>  drivers/net/ethernet/moxa/moxart_ether.c      |  6 ++---
>  .../ethernet/samsung/sxgbe/sxgbe_platform.c   | 24 +++++++------------

coccicheck says:

drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:130:6-26: WARNING: Unsigned expression compared with zero: priv -> rxq [ i ] -> irq_no < 0
drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:124:6-26: WARNING: Unsigned expression compared with zero: priv -> txq [ i ] -> irq_no < 0
drivers/net/ethernet/moxa/moxart_ether.c:468:5-8: WARNING: Unsigned expression compared with zero: irq < 0

Is this really worth the review effort? :|

Please do not send any more conversions unless the old API is clearly
deprecated. 
-- 
pw-bot: cr