netdev - Re: Testing selectable timestamping - where are the tools for this feature?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241113180226.78d8d1ab@kmaincent-XPS-13-7390>
Date: Wed, 13 Nov 2024 18:02:26 +0100
From: Kory Maincent <kory.maincent@...tlin.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Subject: Re: Testing selectable timestamping - where are the tools for this
 feature?

On Wed, 13 Nov 2024 16:52:20 +0000
"Russell King (Oracle)" <linux@...linux.org.uk> wrote:

> On Wed, Nov 13, 2024 at 05:14:43PM +0100, Kory Maincent wrote:
> > On Wed, 13 Nov 2024 15:57:56 +0000
> > "Russell King (Oracle)" <linux@...linux.org.uk> wrote:
> >   
> > > On Wed, Nov 13, 2024 at 04:16:02PM +0100, Kory Maincent wrote:  
>  [...]  
>  [...]  
>  [...]  
> > > 
> > > Thanks... fairly unweildly but at least it's functional. However,
> > > running the first, I immediately find a problem:
> > > 
> > > # ./ynl/cli.py --spec netlink/specs/ethtool.yaml --no-schema --dump
> > > tsinfo-get --json '{"header":{"dev-name":"eth0"}}'
> > > 
> > > One would expect this to only return results for eth0 ?  
> > 
> > Indeed it should! That's weird, I will investigate.
> >   
> > > Also, I don't see more than one timestamper on any interface - there
> > > should be two on eth2, one for the MAC and one for the PHY. I see the
> > > timestamper for the mvpp2 MAC, but nothing for the PHY. The PTP clock
> > > on the PHY is definitely registered (/dev/ptp0), which means
> > > phydev->mii_ts should be pointing to the MII timestamper for the PHY.
> > > 
> > > I've also tried with --json '{"header":{"dev-name":"eth2"}}' but no
> > > difference - it still reports all interfaces and only one timestamper
> > > for eth2.  
> > 
> > Sorry forgot to explain that you need to register PTP clock with the
> > function phydev_ptp_clock_register() in the PHY driver.  
> 
> That is certainly inconvenient. Marvell's PHY PTP/TAI implementation is
> used elsewhere, so the TAI driver is not specific to it being on a PHY.
> The drivers/ptp/marvell*.c that you find in my patches is meant to
> eventually replace drivers/net/dsa/mv88e6xxx/ptp.c - the same hardware
> block is in Marvell's DSA switches.
> 
> > It will be changed in v20 as request by Jakub. I will save the hwtstamp
> > source and phydev pointer in the netdev core instead.  
> 
> I think I'll shelve this until that happens, hopefully that will mean
> my existing code will work and remain a re-usable library.

Ack, Thanks anyway.

-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com