netdev - Re: [PATCH net v6] net: sched: cls_u32: Fix u32's systematic failure to free IDR entries for hnodes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241112175713.6542a5cf@kernel.org>
Date: Tue, 12 Nov 2024 17:57:13 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Jamal Hadi Salim <jhs@...atatu.com>
Cc: Alexandre Ferrieux <alexandre.ferrieux@...il.com>, Eric Dumazet
 <edumazet@...gle.com>, Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko
 <jiri@...nulli.us>, alexandre.ferrieux@...nge.com, Linux Kernel Network
 Developers <netdev@...r.kernel.org>, Simon Horman <horms@...ge.net.au>,
 Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net v6] net: sched: cls_u32: Fix u32's systematic
 failure to free IDR entries for hnodes.

On Tue, 12 Nov 2024 12:07:10 -0500 Jamal Hadi Salim wrote:
> On Tue, Nov 12, 2024 at 10:18 AM Jakub Kicinski <kuba@...nel.org> wrote:
> > I'm used to merging the fix with the selftest, two minor reasons pro:
> >  - less burden on submitter
> >  - backporters can see and use the test to validate, immediately
> > con:
> >  - higher risk of conflicts, but that's my problem (we really need to
> >    alpha-sort the makefiles, sigh)  
> 
> Sounds sensible to me - would help to burn it into scripture.

How does this sound?

  Co-posting selftests
  --------------------

  Selftests should be part of the same series as the code changes.
  Specifically for fixes both code change and related test should go into
  the same tree (the tests may lack a Fixes tag, which is expected).
  Mixing code changes and test changes in a single commit is discouraged.