netdev - Re: [PATCH net v4 6/7] octeon_ep_vf: add protective null checks in napi callbacks for cn9k cards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fec1ffc1-fae0-42b4-bbfc-0f034f020a52@linux.dev>
Date: Wed, 13 Nov 2024 18:02:57 +0000
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Shinas Rasheed <srasheed@...vell.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: hgani@...vell.com, sedara@...vell.com, vimleshk@...vell.com,
 thaller@...hat.com, wizhao@...hat.com, kheib@...hat.com, egallen@...hat.com,
 konguyen@...hat.com, horms@...nel.org,
 Veerasenareddy Burru <vburru@...vell.com>,
 Satananda Burla <sburla@...vell.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net v4 6/7] octeon_ep_vf: add protective null checks in
 napi callbacks for cn9k cards

On 13/11/2024 11:13, Shinas Rasheed wrote:
> During unload, at times the OQ parsed in the napi callbacks
> have been observed to be null, causing system crash.
> Add protective checks to avoid the same, for cn9k cards.
> 
> Fixes: cb7dd712189f ("octeon_ep_vf: Add driver framework and device initialization")
> Signed-off-by: Shinas Rasheed <srasheed@...vell.com>
> ---
> V4:
>    - No changes
> 
> V3: https://lore.kernel.org/all/20241108074543.1123036-7-srasheed@marvell.com/
>    - Added back "Fixes" to the changelist
> 
> V2: https://lore.kernel.org/all/20241107132846.1118835-7-srasheed@marvell.com/
>    - Split into a separate patch
>    - Added more context
> 
> V1: https://lore.kernel.org/all/20241101103416.1064930-4-srasheed@marvell.com/
> 
>   drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_cn9k.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_cn9k.c b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_cn9k.c
> index 88937fce75f1..f1b7eda3fa42 100644
> --- a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_cn9k.c
> +++ b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_cn9k.c
> @@ -273,8 +273,14 @@ static irqreturn_t octep_vf_ioq_intr_handler_cn93(void *data)
>   	struct octep_vf_oq *oq;
>   	u64 reg_val;
>   
> -	oct = vector->octep_vf_dev;
> +	if (!vector)
> +		return IRQ_HANDLED;

And again, this function is irq handler, which is
called from octep_vf_ioq_intr_handler() only if ioq_vector was properly
resolved. This check makes no sense here.

The same goes to the next patch.

> +
>   	oq = vector->oq;
> +	if (!oq)
> +		return IRQ_HANDLED;
> +
> +	oct = vector->octep_vf_dev;
>   	/* Mailbox interrupt arrives along with interrupt of tx/rx ring pair 0 */
>   	if (oq->q_no == 0) {
>   		reg_val = octep_vf_read_csr64(oct, CN93_VF_SDP_R_MBOX_PF_VF_INT(0));