netdev - Re: [PATCH V3 net-next 5/7] net: hibmcge: Add pauseparam supported in this module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <08bbffc1-3c99-4b4a-a3b3-02707752398b@lunn.ch>
Date: Wed, 13 Nov 2024 21:41:06 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Jijie Shao <shaojijie@...wei.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
	shenjian15@...wei.com, wangpeiyang1@...wei.com,
	liuyonglong@...wei.com, chenhao418@...wei.com,
	sudongming1@...wei.com, xujunsheng@...wei.com,
	shiyongbang@...wei.com, libaihan@...wei.com,
	jonathan.cameron@...wei.com, shameerali.kolothum.thodi@...wei.com,
	salil.mehta@...wei.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3 net-next 5/7] net: hibmcge: Add pauseparam supported
 in this module

> Maybe there is an error in this code.
> If I want to disable auto-neg pause, do I need to set phy_set_asym_pause(phydev, 0, 0)?

You could. It is not actually clear to me what you should tell the
link peer when you decide to not use pause autoneg. By passing 0, 0,
you are telling the peer you don't support pause, when in fact you do,
and the configuration is hard coded. Not using pause autoneg really
only makes sense when you do it to both peers. And then the
negotiation configuration does not matter.

phylink makes this a lot easier, it hides this all away, leaving the
MAC driver to just program the hardware.

	Andrew