netdev - Re: [PATCH net-next] net: page_pool: do not count normal frag allocation in stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <173147403525.787328.3977104280425913480.git-patchwork-notify@kernel.org>
Date: Wed, 13 Nov 2024 05:00:35 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, hawk@...nel.org, ilias.apalodimas@...aro.org,
 lorenzo@...nel.org, wangjie125@...wei.com, huangguangbin2@...wei.com
Subject: Re: [PATCH net-next] net: page_pool: do not count normal frag allocation
 in stats

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Fri,  8 Nov 2024 18:33:03 -0800 you wrote:
> Commit 0f6deac3a079 ("net: page_pool: add page allocation stats for
> two fast page allocate path") added increments for "fast path"
> allocation to page frag alloc. It mentions performance degradation
> analysis but the details are unclear. Could be that the author
> was simply surprised by the alloc stats not matching packet count.
> 
> In my experience the key metric for page pool is the recycling rate.
> Page return stats, however, count returned _pages_ not frags.
> This makes it impossible to calculate recycling rate for drivers
> using the frag API. Here is example output of the page-pool
> YNL sample for a driver allocating 1200B frags (4k pages)
> with nearly perfect recycling:
> 
> [...]

Here is the summary with links:
  - [net-next] net: page_pool: do not count normal frag allocation in stats
    https://git.kernel.org/netdev/net-next/c/ef04d290c013

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html