netdev - Re: [PATCHv3 net-next] net: mellanox: use ethtool string helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZzRzZpReQM0JCACW@shredder>
Date: Wed, 13 Nov 2024 11:37:42 +0200
From: Ido Schimmel <idosch@...dia.com>
To: Rosen Penev <rosenp@...il.com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Petr Machata <petrm@...dia.com>,
	Richard Cochran <richardcochran@...il.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv3 net-next] net: mellanox: use ethtool string helpers

Thanks for the patch, but there are a few process issues.

On Tue, Nov 12, 2024 at 01:17:11PM -0800, Rosen Penev wrote:
> These are the preferred way to copy ethtool strings.
> 
> Avoids incrementing pointers all over the place.
> 
> Signed-off-by: Rosen Penev <rosenp@...il.com>
> Reviewed-by: Ido Schimmel <idosch@...dia.com>

I only tagged the mlxsw change. The mlxbf change is new.

> ---
>  v3: also convert memcpy.
>  v2: rebase to make it apply.
>  .../mellanox/mlxbf_gige/mlxbf_gige_ethtool.c  |  5 +-

Please split the mlxbf change to a different patch and copy the relevant
maintainers:

davthompson@...dia.com
asmaa@...dia.com

Use "mlxbf_gige:" prefix for the mlxbf patch and "mlxsw:" for the mlxsw
patch. You can keep my tag on the latter.


>  .../mellanox/mlxsw/spectrum_ethtool.c         | 83 +++++++------------
>  .../ethernet/mellanox/mlxsw/spectrum_ptp.c    |  7 +-
>  3 files changed, 33 insertions(+), 62 deletions(-)