netdev - Re: [bug report] xfrm: Cache used outbound xfrm states at the policy.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZzXXayCCZ2zV4f1u@gauss3.secunet.de>
Date: Thu, 14 Nov 2024 11:56:43 +0100
From: Steffen Klassert <steffen.klassert@...unet.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Simon Horman <horms@...nel.org>, <netdev@...r.kernel.org>
Subject: Re: [bug report] xfrm: Cache used outbound xfrm states at the policy.

On Tue, Nov 12, 2024 at 01:24:08PM +0300, Dan Carpenter wrote:
...
>     1468                 if (km_query(x, tmpl, pol) == 0) {
>     1469                         spin_lock_bh(&net->xfrm.xfrm_state_lock);
>     1470                         x->km.state = XFRM_STATE_ACQ;
>     1471                         x->dir = XFRM_SA_DIR_OUT;
>     1472                         list_add(&x->km.all, &net->xfrm.state_all);
> --> 1473                         XFRM_STATE_INSERT(bydst, &x->bydst,
>     1474                                           net->xfrm.state_bydst + h,
>                                                                            ^
> Potentially uninitialized?

A new goto jumped over the initialization of 'h'.

I'll initialize it now explicitly before we use it here.

Thanks for the report!