netdev - Re: [Bug report] NFS patch breaks TLS device-offloaded TX zerocopy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bfeeaccd-dc8f-4f9b-bbae-4b13547bd04d@gmail.com>
Date: Thu, 14 Nov 2024 21:05:00 +0200
From: Tariq Toukan <ttoukan.linux@...il.com>
To: Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>,
 Anna Schumaker <Anna.Schumaker@...app.com>,
 Trond Myklebust <trondmy@...nel.org>, linux-nfs@...r.kernel.org,
 Boris Pismenny <borisp@...dia.com>, John Fastabend
 <john.fastabend@...il.com>, Jakub Kicinski <kuba@...nel.org>
Cc: Saeed Mahameed <saeedm@...dia.com>, Gal Pressman <gal@...dia.com>,
 Networking <netdev@...r.kernel.org>, Paolo Abeni <pabeni@...hat.com>,
 Eric Dumazet <edumazet@...gle.com>, "David S. Miller" <davem@...emloft.net>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 Leon Romanovsky <leon@...nel.org>, Tariq Toukan <tariqt@...dia.com>,
 Dragos Tatulea <dtatulea@...dia.com>
Subject: Re: [Bug report] NFS patch breaks TLS device-offloaded TX zerocopy

On 05/08/2024 13:40, Tariq Toukan wrote:
> Hi,
> 
> A recent patch [1] to 'fs' broke the TX TLS device-offloaded flow 
> starting from v6.11-rc1.
> 
> The kernel crashes. Different runs result in different kernel traces.
> See below [2].
> All of them disappear once patch [1] is reverted.
> 
> The issues appears only with "sendfile on and zerocopy on".
> We couldn't repro with "sendfile off", or with "sendfile on and zerocopy 
> off".
> 
> The repro test is as simple as a repeated client/server communication 
> (wrk/nginx), with sendfile on and zc on, and with "tls-hw-tx-offload: on".
> 
> $ for i in `seq 10`; do wrk -b::2:2:2:3 -t10 -c100 -d15 --timeout 5s 
> https://[::2:2:2:2]:20448/16000b.img; done
> 
> We can provide more details if needed, to help with the analysis and debug.
> 
> Regards,
> Tariq
> 
> [1]
> commit 49b29a573da83b65d5f4ecf2db6619bab7aa910c
> Author: Christoph Hellwig <hch@....de>
> Date:   Mon May 27 18:36:09 2024 +0200
> 
>      nfs: add support for large folios
> 
>      NFS already is void of folio size assumption, so just pass the 
> chunk size
>      to __filemap_get_folio and set the large folio address_space flag 
> for all
>      regular files.
> 
>      Signed-off-by: Christoph Hellwig <hch@....de>
>      Tested-by: Sagi Grimberg <sagi@...mberg.me>
>      Signed-off-by: Anna Schumaker <Anna.Schumaker@...app.com>
> 
>   fs/nfs/file.c  | 4 +++-
>   fs/nfs/inode.c | 1 +
>   2 files changed, 4 insertions(+), 1 deletion(-)
> 
> 

Hi all,

FYI, issue is fixed by:

commit dd6e972cc589 ("net/mlx5e: kTLS, Fix incorrect page refcounting")

https://lore.kernel.org/netdev/20241107183527.676877-5-tariqt@nvidia.com/

Thanks,
Tariq