netdev - Re: [PATCH net-next v2 00/12] Begin upstreaming Homa transport protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e5053f9e-3dc7-4a71-9a3a-f8492987f21f@infradead.org>
Date: Thu, 14 Nov 2024 11:36:35 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: John Ousterhout <ouster@...stanford.edu>,
 Cong Wang <xiyou.wangcong@...il.com>
Cc: netdev@...r.kernel.org, linux-api@...r.kernel.org
Subject: Re: [PATCH net-next v2 00/12] Begin upstreaming Homa transport
 protocol



On 11/14/24 8:59 AM, John Ousterhout wrote:
> On Wed, Nov 13, 2024 at 9:08 AM Cong Wang <xiyou.wangcong@...il.com> wrote:
>>
>> On Mon, Nov 11, 2024 at 03:39:53PM -0800, John Ousterhout wrote:
>>>  MAINTAINERS               |    7 +
>>>  include/uapi/linux/homa.h |  165 ++++++
>>>  net/Kconfig               |    1 +
>>>  net/Makefile              |    1 +
>>>  net/homa/Kconfig          |   19 +
>>>  net/homa/Makefile         |   14 +
>>>  net/homa/homa_impl.h      |  767 ++++++++++++++++++++++++++
>>>  net/homa/homa_incoming.c  | 1076 +++++++++++++++++++++++++++++++++++++
>>>  net/homa/homa_outgoing.c  |  854 +++++++++++++++++++++++++++++
>>>  net/homa/homa_peer.c      |  319 +++++++++++
>>>  net/homa/homa_peer.h      |  234 ++++++++
>>>  net/homa/homa_plumbing.c  |  965 +++++++++++++++++++++++++++++++++
>>>  net/homa/homa_pool.c      |  420 +++++++++++++++
>>>  net/homa/homa_pool.h      |  152 ++++++
>>>  net/homa/homa_rpc.c       |  488 +++++++++++++++++
>>>  net/homa/homa_rpc.h       |  446 +++++++++++++++
>>>  net/homa/homa_sock.c      |  380 +++++++++++++
>>>  net/homa/homa_sock.h      |  426 +++++++++++++++
>>>  net/homa/homa_stub.h      |   80 +++
>>>  net/homa/homa_timer.c     |  156 ++++++
>>>  net/homa/homa_utils.c     |  150 ++++++
>>>  net/homa/homa_wire.h      |  378 +++++++++++++
>>
>> Hi John,
>>
>> Thanks for your efforts to push them upstream!
>>
>> Just some very high-level comments:
>>
>> 1. Please run scripts/checkpatch.pl to make sure the coding style is
>> aligned with upstream, since I noticed there are still some C++ style
>> comments in your patchset.
> 
> I have been running checkpatch.pl, but it didn't complain about C++
> style comments. Those comments really shouldn't be there, though: they
> are for pieces of code I've temporarily commented out, and those
> chunks shouldn't be in the upstream version of Homa. I'll fix things
> so they don't appear in the future.
> 

John, you should be OK using // comments if that's what you want to use.

https://lkml.iu.edu/hypermail/linux/kernel/1607.1/00627.html
or
https://lore.kernel.org/lkml/CA+55aFyQYJerovMsSoSKS7PessZBr4vNp-3QUUwhqk4A4_jcbg@mail.gmail.com/

are still current AFAIK.


-- 
~Randy