netdev - Re: [PATCH] net: wwan: Add WWAN sahara port type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <60875bc8-bc45-4168-8568-38ec73499d1b@gmail.com>
Date: Thu, 14 Nov 2024 22:16:44 +0200
From: Sergey Ryazanov <ryazanov.s.a@...il.com>
To: Jerry Meng(蒙杰) <jerry.meng@...ctel.com>
Cc: "loic.poulain@...aro.org" <loic.poulain@...aro.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: wwan: Add WWAN sahara port type

Hello Jerry,

On 14.11.2024 10:45, Jerry Meng(蒙杰) wrote:
> Add a Sahara protocol-based interface for downloading ramdump
> from Qualcomm modems in SBL ramdump mode.
> 
> Signed-off-by: Jerry Meng <jerry.meng@...ctel.com>
> ---
>   drivers/net/wwan/mhi_wwan_ctrl.c | 3 ++-
>   drivers/net/wwan/wwan_core.c     | 4 ++++
>   include/linux/wwan.h             | 2 ++
>   3 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wwan/mhi_wwan_ctrl.c b/drivers/net/wwan/mhi_wwan_ctrl.c
> index e9f979d2d..2c6a754af 100644
> --- a/drivers/net/wwan/mhi_wwan_ctrl.c
> +++ b/drivers/net/wwan/mhi_wwan_ctrl.c
> @@ -263,7 +263,8 @@ static const struct mhi_device_id mhi_wwan_ctrl_match_table[] = {
>   	{ .chan = "QMI", .driver_data = WWAN_PORT_QMI },
>   	{ .chan = "DIAG", .driver_data = WWAN_PORT_QCDM },
>   	{ .chan = "FIREHOSE", .driver_data = WWAN_PORT_FIREHOSE },
> -	{},
> +        { .chan = "SAHARA", .driver_data = WWAN_PORT_SAHARA},
                                                               ^
          White space is missed between the port type and '}' -'

Please run the checkpatch.pl before submission, and use 
git-send-email(1) when it is possible.


$ ./scripts/checkpatch.pl net-wwan-Add-WWAN-sahara-port-type.patch
...
total: 6 errors, 6 warnings, 33 lines check

--
Sergey