netdev - Re: [PATCH bpf] xsk: Free skb when TX metadata options are invalid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e5edc796-7ae3-4b57-b8ee-223f2c26f936@linux.dev>
Date: Thu, 14 Nov 2024 13:43:22 -0800
From: Martin KaFai Lau <martin.lau@...ux.dev>
To: Felix Maurer <fmaurer@...hat.com>, Jakub Kicinski <kuba@...nel.org>
Cc: bjorn@...nel.org, magnus.karlsson@...el.com,
 maciej.fijalkowski@...el.com, jonathan.lemon@...il.com, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
 ast@...nel.org, daniel@...earbox.net, hawk@...nel.org,
 john.fastabend@...il.com, yoong.siang.song@...el.com, sdf@...ichev.me,
 netdev@...r.kernel.org, Michal Schmidt <mschmidt@...hat.com>,
 bpf@...r.kernel.org
Subject: Re: [PATCH bpf] xsk: Free skb when TX metadata options are invalid

On 11/14/24 3:30 AM, Felix Maurer wrote:
> When a new skb is allocated for transmitting an xsk descriptor, i.e., for
> every non-multibuf descriptor or the first frag of a multibuf descriptor,
> but the descriptor is later found to have invalid options set for the TX
> metadata, the new skb is never freed. This can leak skbs until the send
> buffer is full which makes sending more packets impossible.
> 
> Fix this by freeing the skb in the error path if we are currently dealing
> with the first frag, i.e., an skb allocated in this iteration of
> xsk_build_skb.

Acked-by: Martin KaFai Lau <martin.lau@...nel.org>

Jakub, can you help to take it directly to the net tree? Thanks!