netdev - 回覆: 回覆: [net-next 3/3] net: ftgmac100: Support for AST2700

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SEYPR06MB51340B957ED63E32BEDFBEDF9D5B2@SEYPR06MB5134.apcprd06.prod.outlook.com>
Date: Thu, 14 Nov 2024 06:26:46 +0000
From: Jacky Chou <jacky_chou@...eedtech.com>
To: Andrew Lunn <andrew@...n.ch>
CC: "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>, "ratbert@...aday-tech.com"
	<ratbert@...aday-tech.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject:
 回覆: 回覆: [net-next 3/3] net: ftgmac100: Support for AST2700

Hi Andrew,


> > > > -	map = le32_to_cpu(rxdes->rxdes3);
> > > > +	map = le32_to_cpu(rxdes->rxdes3) | ((rxdes->rxdes2 &
> > > > +FTGMAC100_RXDES2_RXBUF_BADR_HI) << 16);
> > >
> > > Is this safe? You have to assume older generation of devices will
> > > return 42 in rxdes3, since it is not used by the hardware.
> >
> > Why does it need to return 42 in rxdes3?
> > The packet buffer address of the RX descriptor is used in both software and
> hardware.
> 
> 42 is just a random value. The point is, what do older generation of devices
> return here? Some random value? Something well defined?
> 
> You basically need to convince us that you are not breaking older systems by
> accessing registers which they do not have. Describe in the commit message
> how you know this is safe, what testing you have done etc.

Thanks for your kind reminder.
I will commit more detail information in next version.

Thanks,
Jacky