netdev - Re: [PATCH net v6] net: sched: cls_u32: Fix u32's systematic failure to free IDR entries for hnodes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241113164110.196f491d@kernel.org>
Date: Wed, 13 Nov 2024 16:41:10 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Jamal Hadi Salim <jhs@...atatu.com>
Cc: Alexandre Ferrieux <alexandre.ferrieux@...il.com>, Eric Dumazet
 <edumazet@...gle.com>, Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko
 <jiri@...nulli.us>, alexandre.ferrieux@...nge.com, Linux Kernel Network
 Developers <netdev@...r.kernel.org>, Simon Horman <horms@...ge.net.au>,
 Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net v6] net: sched: cls_u32: Fix u32's systematic
 failure to free IDR entries for hnodes.

On Wed, 13 Nov 2024 09:17:09 -0500 Jamal Hadi Salim wrote:
> >   Co-posting selftests
> >   --------------------
> >
> >   Selftests should be part of the same series as the code changes.
> >   Specifically for fixes both code change and related test should go into
> >   the same tree (the tests may lack a Fixes tag, which is expected).
> >   Mixing code changes and test changes in a single commit is discouraged.  
> 
> Just the last sentence:
> Mixing unrelated (to the fix) code changes and test changes in a
> single commit is discouraged.

Perfect example why things are not documented.
I have no idea what you're trying to say..
I think you're the only person who is getting this wrong,
so I'll toss the documentation patch.