netdev - Re: [PATCH net-next V2 3/8] devlink: Extend devlink rate API with traffic classes bandwidth management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6e5e26b7-9682-49e4-bc2e-7683967a8c78@redhat.com>
Date: Fri, 15 Nov 2024 11:15:27 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Tariq Toukan <tariqt@...dia.com>, "David S. Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Eric Dumazet <edumazet@...gle.com>, Andrew Lunn <andrew+netdev@...n.ch>
Cc: netdev@...r.kernel.org, Saeed Mahameed <saeedm@...dia.com>,
 Gal Pressman <gal@...dia.com>, Leon Romanovsky <leonro@...dia.com>,
 Jiri Pirko <jiri@...nulli.us>, Carolina Jubran <cjubran@...dia.com>,
 Cosmin Ratiu <cratiu@...dia.com>
Subject: Re: [PATCH net-next V2 3/8] devlink: Extend devlink rate API with
 traffic classes bandwidth management

On 11/14/24 23:09, Tariq Toukan wrote:
> From: Carolina Jubran <cjubran@...dia.com>
> 
> Introduce support for specifying bandwidth proportions between traffic
> classes (TC) in the devlink-rate API. This new option allows users to
> allocate bandwidth across multiple traffic classes in a single command.
> 
> This feature provides a more granular control over traffic management,
> especially for scenarios requiring Enhanced Transmission Selection.
> 
> Users can now define a specific bandwidth share for each traffic class,
> such as allocating 20% for TC0 (TCP/UDP) and 80% for TC5 (RoCE).
> 
> Example:
> DEV=pci/0000:08:00.0
> 
> $ devlink port function rate add $DEV/vfs_group tx_share 10Gbit \
>   tx_max 50Gbit tc-bw 0:20 1:0 2:0 3:0 4:0 5:80 6:0 7:0
> 
> $ devlink port function rate set $DEV/vfs_group \
>   tc-bw 0:20 1:0 2:0 3:0 4:0 5:10 6:60 7:0
> 
> Signed-off-by: Carolina Jubran <cjubran@...dia.com>
> Reviewed-by: Cosmin Ratiu <cratiu@...dia.com>
> Signed-off-by: Tariq Toukan <tariqt@...dia.com>

I haven't dug into it, but this patch is apparently causing netdevsim
self-tests failures:

https://netdev-3.bots.linux.dev/vmksft-netdevsim/results/860662/4-devlink-sh/stdout

Could you please have a look?

Thanks!

Paolo