netdev - Re: [PATCH net-next] net/neighbor: clear error in case strict check is not set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241115140614.GS1062410@kernel.org>
Date: Fri, 15 Nov 2024 14:06:14 +0000
From: Simon Horman <horms@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, joel.granados@...nel.org
Subject: Re: [PATCH net-next] net/neighbor: clear error in case strict check
 is not set

On Thu, Nov 14, 2024 at 04:32:21PM -0800, Jakub Kicinski wrote:
> Commit 51183d233b5a ("net/neighbor: Update neigh_dump_info for strict
> data checking") added strict checking. The err variable is not cleared,
> so if we find no table to dump we will return the validation error even
> if user did not want strict checking.
> 
> I think the only way to hit this is to send an buggy request, and ask
> for a table which doesn't exist, so there's no point treating this
> as a real fix. I only noticed it because a syzbot repro depended on it
> to trigger another bug.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: joel.granados@...nel.org

Reviewed-by: Simon Horman <horms@...nel.org>