netdev - Re: [PATCH net-next] selftests: net: netlink-dumps: validation checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241115145212.GT1062410@kernel.org>
Date: Fri, 15 Nov 2024 14:52:12 +0000
From: Simon Horman <horms@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next] selftests: net: netlink-dumps: validation checks

On Thu, Nov 14, 2024 at 04:32:48PM -0800, Jakub Kicinski wrote:
> The sanity checks are going to get silently cast to unsigned
> and always pass. Cast the sizeof to signed size.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Ouch. I checked and I couldn't see any other instances of this problem
under tools/testing/selftests/net/

Reviewed-by: Simon Horman <horms@...nel.org>