netdev - Re: [PATCH net-next v23 1/7] mm: page_frag: add a test module for page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZzdWuUgyAET1babn@finisterre.sirena.org.uk>
Date: Fri, 15 Nov 2024 14:12:09 +0000
From: Mark Brown <broonie@...nel.org>
To: Yunsheng Lin <linyunsheng@...wei.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Alexander Duyck <alexander.duyck@...il.com>,
	Linux-MM <linux-mm@...ck.org>,
	Alexander Duyck <alexanderduyck@...com>,
	Shuah Khan <shuah@...nel.org>, linux-kselftest@...r.kernel.org,
	Aishwarya.TCV@....com
Subject: Re: [PATCH net-next v23 1/7] mm: page_frag: add a test module for
 page_frag

On Fri, Nov 15, 2024 at 05:03:34PM +0800, Yunsheng Lin wrote:
> On 2024/11/15 0:02, Mark Brown wrote:
> > On Mon, Oct 28, 2024 at 07:53:36PM +0800, Yunsheng Lin wrote:

> > This is breaking the build in -next on at least arm64 and x86_64 since
> > it's trying to build an out of tree kernel module which is included in
> > the selftests directory, the kselftest build system just isn't set up to
> > do that in a sensible and robust fashion.  The module should probably be

> I tried the below kernel modules in the testing directory, they seemed to
> have the similar problem if the kernel is not compiled yet.

> make -C tools/testing/nvdimm

This is not included in the top level selftests Makefile.

> make -C tools/testing/selftests/bpf/bpf_testmod/

The BPF tests aren't built as standard due to a number of issues,
originally it was requiring very shiny toolchains though that's starting
to get under control.

> make -C tools/testing/selftests/livepatch/test_modules/

Ah, this one is actually using some framework support for building
modules - it's putting the modules in a separate directory and using
TEST_GEN_MODS_DIR.  Crucially, though, it has guards which ensure that
we don't try to build the modules if KDIR doesn't exist - you should
follow that pattern.

> > in the main kernel tree and enabled by the config file for the mm tests.

> As discussed in [1], this module is not really a vaild kernel module by
> returning '-EAGAIN', which is the main reason that it is setup in the
> selftests instead of the main kernel tree.

Sure, we have other test stuff in the main kernel.

> As above, I am not sure if there is some elegant way to avoid the above error
> in the selftest core, one possible way to avoid the above error is to skip
> compiling like below as tools/testing/selftests/mm/test_page_frag.sh already
> skip the testing for page_frag if the test module is not compiled:

Since the tests currently don't build the test systems are by and by
large not getting as far as trying to run anything, the entire mm suite
is just getting skipped.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)