netdev - Re: [PATCH net-next v5 5/7] bnxt_en: add support for header-data-split-thresh ethtool command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMArcTU5Ew4yrpjy9ceB4iSgU0rn_GiH0KqyZe_aGtsuAN75Og@mail.gmail.com>
Date: Sat, 16 Nov 2024 01:18:05 +0900
From: Taehee Yoo <ap420073@...il.com>
To: Michael Chan <michael.chan@...adcom.com>
Cc: Andy Gospodarek <andrew.gospodarek@...adcom.com>, davem@...emloft.net, kuba@...nel.org, 
	pabeni@...hat.com, edumazet@...gle.com, almasrymina@...gle.com, 
	donald.hunter@...il.com, corbet@....net, andrew+netdev@...n.ch, 
	hawk@...nel.org, ilias.apalodimas@...aro.org, ast@...nel.org, 
	daniel@...earbox.net, john.fastabend@...il.com, dw@...idwei.uk, 
	sdf@...ichev.me, asml.silence@...il.com, brett.creeley@....com, 
	linux-doc@...r.kernel.org, netdev@...r.kernel.org, kory.maincent@...tlin.com, 
	maxime.chevallier@...tlin.com, danieller@...dia.com, hengqi@...ux.alibaba.com, 
	ecree.xilinx@...il.com, przemyslaw.kitszel@...el.com, hkallweit1@...il.com, 
	ahmed.zaki@...el.com, rrameshbabu@...dia.com, idosch@...dia.com, 
	jiri@...nulli.us, bigeasy@...utronix.de, lorenzo@...nel.org, 
	jdamato@...tly.com, aleksander.lobakin@...el.com, kaiyuanz@...gle.com, 
	willemb@...gle.com, daniel.zahka@...il.com
Subject: Re: [PATCH net-next v5 5/7] bnxt_en: add support for
 header-data-split-thresh ethtool command

On Fri, Nov 15, 2024 at 9:27 AM Michael Chan <michael.chan@...adcom.com> wrote:
>

Hi Michael,
Thank you so much for the review!

> On Thu, Nov 14, 2024 at 2:54 PM Andy Gospodarek
> <andrew.gospodarek@...adcom.com> wrote:
> >
> > On Wed, Nov 13, 2024 at 05:32:19PM +0000, Taehee Yoo wrote:
> > > The bnxt_en driver has configured the hds_threshold value automatically
> > > when TPA is enabled based on the rx-copybreak default value.
> > > Now the header-data-split-thresh ethtool command is added, so it adds an
> > > implementation of header-data-split-thresh option.
> > >
> > > Configuration of the header-data-split-thresh is allowed only when
> > > the header-data-split is enabled. The default value of
> > > header-data-split-thresh is 256, which is the default value of
> > > rx-copybreak, which used to be the hds_thresh value.
> > >
> > >    # Example:
> > >    # ethtool -G enp14s0f0np0 tcp-data-split on header-data-split-thresh 256
> > >    # ethtool -g enp14s0f0np0
> > >    Ring parameters for enp14s0f0np0:
> > >    Pre-set maximums:
> > >    ...
> > >    Header data split thresh:  256
> > >    Current hardware settings:
> > >    ...
> > >    TCP data split:         on
> > >    Header data split thresh:  256
> > >
> > > Tested-by: Stanislav Fomichev <sdf@...ichev.me>
> > > Signed-off-by: Taehee Yoo <ap420073@...il.com>
> >
> > Tested-by: Andy Gospodarek <gospo@...adcom.com>
> >
>
> > > @@ -2362,6 +2362,8 @@ struct bnxt {
> > >       u8                      q_ids[BNXT_MAX_QUEUE];
> > >       u8                      max_q;
> > >       u8                      num_tc;
> > > +#define BNXT_HDS_THRESHOLD_MAX       256
>
> As mentioned in my comments for patch #1, our NIC can support HDS
> threshold of up to 1023, so we can set this to 1023.  Thanks.

Thanks for checking, I will change it to 1023.

Thanks a lot!
Taehee Yoo