netdev - Re: [PATCH net 1/2] netlink: fix false positive warning in extack during dumps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241115083816.3040dffe@kernel.org>
Date: Fri, 15 Nov 2024 08:38:16 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Simon Horman <horms@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, syzbot+d4373fa8042c06cefa84@...kaller.appspotmail.com,
 dsahern@...nel.org
Subject: Re: [PATCH net 1/2] netlink: fix false positive warning in extack
 during dumps

On Fri, 15 Nov 2024 14:00:07 +0000 Simon Horman wrote:
> > + * nlmsg_addr_in_payload - address points to a byte within the message payload
> > + * @nlh: netlink message header  
> 
> nit: something about @addr should go here.

Ah, thanks, I just sent a mass conversion, the missing Return
statements make the warnings hard to spot.

I'll also move the warning into the helper in v2, I hate 
the double negation in the caller.
-- 
pw-bot: cr