netdev - Re: [PATCH net-next v5 4/7] net: ethtool: add support for configuring header-data-split-thresh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMArcTUfGp0SEm=w3dg=GHd52w4zw2kG7mGLsaP4b9NjTYMTrw@mail.gmail.com>
Date: Sat, 16 Nov 2024 03:05:33 +0900
From: Taehee Yoo <ap420073@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com, 
	almasrymina@...gle.com, donald.hunter@...il.com, corbet@....net, 
	michael.chan@...adcom.com, andrew+netdev@...n.ch, hawk@...nel.org, 
	ilias.apalodimas@...aro.org, ast@...nel.org, daniel@...earbox.net, 
	john.fastabend@...il.com, dw@...idwei.uk, sdf@...ichev.me, 
	asml.silence@...il.com, brett.creeley@....com, linux-doc@...r.kernel.org, 
	netdev@...r.kernel.org, kory.maincent@...tlin.com, 
	maxime.chevallier@...tlin.com, danieller@...dia.com, hengqi@...ux.alibaba.com, 
	ecree.xilinx@...il.com, przemyslaw.kitszel@...el.com, hkallweit1@...il.com, 
	ahmed.zaki@...el.com, rrameshbabu@...dia.com, idosch@...dia.com, 
	jiri@...nulli.us, bigeasy@...utronix.de, lorenzo@...nel.org, 
	jdamato@...tly.com, aleksander.lobakin@...el.com, kaiyuanz@...gle.com, 
	willemb@...gle.com, daniel.zahka@...il.com
Subject: Re: [PATCH net-next v5 4/7] net: ethtool: add support for configuring header-data-split-thresh

On Fri, Nov 15, 2024 at 1:24 PM Jakub Kicinski <kuba@...nel.org> wrote:
>

Hi Jakub,
Thanks a lot for the review!

> On Wed, 13 Nov 2024 17:32:18 +0000 Taehee Yoo wrote:
> > +  ``ETHTOOL_A_RINGS_HEADER_DATA_SPLIT_THRESH``      u32     threshold of
> > +                                                            header / data split
> > +  ``ETHTOOL_A_RINGS_HEADER_DATA_SPLIT_THRESH_MAX``  u32     max threshold of
>
> nit: s/_HEADER_DATA_SPLIT_/_HDS_/ ;)
>
> We can explain in the text that HDS stands for header data split.
> Let's not bloat the code with 40+ character names...

I'm not familiar with the ynl, but I think there are some dependencies
between Documentation/netlink/spec/ethtool.yaml.
Because It seems to generate ethtool-user.c code automatically based
on ethtool.yaml spec. I think If we change this name to HDS, it need to
change ethtool spec form "header-data-split-thresh" to "hds-thresh" too.

However, I agree with changing ethtool option name from
"header-data-split-thresh" to "hds-thresh". So, If I understand correctly,
what about changing ethtool option name from "header-data-split-thresh"
to "hds-thresh"?

Thanks a lot!
Taehee Yoo