netdev - Re: [PATCH net v1] ice: do not reserve resources for RDMA when disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEuXFEyryE_Cr+=DEzPPZFeOXLn5QpwL57nyxkQ=Eo6eTE3eyQ@mail.gmail.com>
Date: Fri, 15 Nov 2024 10:48:05 -0800
From: Jesse Brandeburg <jbrandeb@...nel.org>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Cc: jbrandeburg@...udflare.com, netdev@...r.kernel.org, 
	intel-wired-lan@...ts.osuosl.org, Dave Ertman <david.m.ertman@...el.com>, 
	Tony Nguyen <anthony.l.nguyen@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	"Czapnik, Lukasz" <lukasz.czapnik@...el.com>, 
	Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>, 
	Pawel Chmielewski <pawel.chmielewski@...el.com>
Subject: Re: [PATCH net v1] ice: do not reserve resources for RDMA when disabled

On Fri, Nov 15, 2024 at 12:51 AM Przemek Kitszel
<przemyslaw.kitszel@...el.com> wrote:
>
> On 11/14/24 01:00, jbrandeb@...nel.org wrote:
> > From: Jesse Brandeburg <jbrandeb@...nel.org>
> >
> > If the CONFIG_INFINIBAND_IRDMA symbol is not enabled as a module or a
> > built-in, then don't let the driver reserve resources for RDMA.
> >
> > Do this by avoiding enabling the capability when scanning hardware
> > capabilities.
> >
> > Fixes: d25a0fc41c1f ("ice: Initialize RDMA support")
> > CC: Dave Ertman <david.m.ertman@...el.com>
> > Signed-off-by: Jesse Brandeburg <jbrandeb@...nel.org>
> > ---
>
> Hi Jesse, it's good to hear back from you :)


Hi Przemek! You too.

> we are already working on resolving the issue of miss-allocating
> too many resources (would be good to know what beyond MSI-x'es
> you care about) for RDMA in the default (likely non-RDMA heavy) case.
> Here is a series from Michal that lets user to manage it a bit:
> https://lore.kernel.org/netdev/20241114122009.97416-3-michal.swiatkowski@linux.intel.com/T/

I agree, but that whole series is far too big to backport to stable, right?

> and we want to post another one later that changes defaults from the
> current "grab a lot when there are many CPUs" policy to more resonable

I'm looking forward to those series, and in fact had been looking to
backport one of the patches from michal's series, but found that for
us at least with RDMA disabled this limit seemed far simpler, and also
I doubt it will conflict with the more complicated work of managing
features when all are enabled.

Please see my other reply to dave (and yes I'm replying from two
different accounts, as I'm figuring out the best way to work here at
my new job.)