netdev - Re: [PATCH iproute2-next] add .editorconfig file for basic formatting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241115123210.752b5580@hermes.local>
Date: Fri, 15 Nov 2024 12:32:10 -0800
From: Stephen Hemminger <stephen@...workplumber.org>
To: Vincent Mailhol <mailhol.vincent@...adoo.fr>
Cc: netdev@...r.kernel.org, David Ahern <dsahern@...il.com>
Subject: Re: [PATCH iproute2-next] add .editorconfig file for basic
 formatting

On Sat, 16 Nov 2024 02:59:01 +0900
Vincent Mailhol <mailhol.vincent@...adoo.fr> wrote:

> > [*]
> > end_of_line = lf
> > insert_final_newline = true
> > trim_trailing_whitespace = true  
> 
> Just let me confirm this one: do you really want the automatic
> whitespace removal? On some editor, it will trim not only the modified
> lines but also any whitespace in the full file.
> 
> This can create "noise" in the patch diff. If you acknowledge this risk,
> then I am fine to keep this parameter.


Yes, emacs and some other editors have bad habit of leaving trailing
whitespace. And sometimes new files get added without new line at end.

Line length should be 100 like kernel.