netdev - [PATCH 0/3] UAPI: ethtool: Avoid flex-array in struct ethtool_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241115204115.work.686-kees@kernel.org>
Date: Fri, 15 Nov 2024 12:43:02 -0800
From: Kees Cook <kees@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Kees Cook <kees@...nel.org>,
	"Gustavo A. R. Silva" <gustavoars@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Andrew Lunn <andrew@...n.ch>,
	"Kory Maincent (Dent Project)" <kory.maincent@...tlin.com>,
	Michael Chan <michael.chan@...adcom.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Eric Dumazet <edumazet@...gle.com>,
	Paolo Abeni <pabeni@...hat.com>,
	Potnuri Bharat Teja <bharat@...lsio.com>,
	Christian Benvenuti <benve@...co.com>,
	Satish Kharat <satishkh@...co.com>,
	Manish Chopra <manishc@...vell.com>,
	Simon Horman <horms@...nel.org>,
	Edward Cree <ecree.xilinx@...il.com>,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Ahmed Zaki <ahmed.zaki@...el.com>,
	Rahul Rameshbabu <rrameshbabu@...dia.com>,
	Ido Schimmel <idosch@...dia.com>,
	Maxime Chevallier <maxime.chevallier@...tlin.com>,
	Takeru Hayasaka <hayatake396@...il.com>,
	Jonathan Corbet <corbet@....net>,
	linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org,
	linux-hardening@...r.kernel.org
Subject: [PATCH 0/3] UAPI: ethtool: Avoid flex-array in struct ethtool_link_settings

Hi,

This reverts the tagged struct group in struct ethtool_link_settings and
instead just removes the flexible array member from Linux's view as it
is entirely unused.

-Kees

Kees Cook (3):
  Revert "net: ethtool: Avoid thousands of
    -Wflex-array-member-not-at-end warnings"
  Revert "UAPI: ethtool: Use __struct_group() in struct
    ethtool_link_settings"
  UAPI: ethtool: Avoid flex-array in struct ethtool_link_settings

 .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c |  6 +--
 .../ethernet/chelsio/cxgb4/cxgb4_ethtool.c    |  4 +-
 .../ethernet/chelsio/cxgb4vf/cxgb4vf_main.c   |  2 +-
 .../net/ethernet/cisco/enic/enic_ethtool.c    |  2 +-
 .../net/ethernet/qlogic/qede/qede_ethtool.c   |  4 +-
 include/linux/ethtool.h                       |  2 +-
 include/uapi/linux/ethtool.h                  | 40 ++++++++++---------
 net/ethtool/ioctl.c                           |  2 +-
 net/ethtool/linkinfo.c                        |  8 ++--
 net/ethtool/linkmodes.c                       | 18 ++++-----
 10 files changed, 44 insertions(+), 44 deletions(-)

-- 
2.34.1