Message-ID: <e1ff4b71-7abf-4ac6-8b82-86aad5394de6@quicinc.com>
Date: Fri, 15 Nov 2024 13:30:34 -0800
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Easwar Hariharan <eahariha@...ux.microsoft.com>,
        Pablo Neira Ayuso
	<pablo@...filter.org>,
        Jozsef Kadlecsik <kadlec@...filter.org>,
        "David S.
 Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Simon Horman
	<horms@...nel.org>,
        Julia Lawall <Julia.Lawall@...ia.fr>,
        Nicolas Palix
	<nicolas.palix@...g.fr>,
        Daniel Mack <daniel@...que.org>,
        Haojian Zhuang
	<haojian.zhuang@...il.com>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Russell
 King <linux@...linux.org.uk>,
        Heiko Carstens <hca@...ux.ibm.com>, Vasily
 Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle
	<svens@...ux.ibm.com>, Ofir Bitton <obitton@...ana.ai>,
        Oded Gabbay
	<ogabbay@...nel.org>,
        Lucas De Marchi <lucas.demarchi@...el.com>,
        Thomas Hellström <thomas.hellstrom@...ux.intel.com>,
        Rodrigo
 Vivi <rodrigo.vivi@...el.com>,
        Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
        Jeroen de Borst <jeroendb@...gle.com>,
        Praveen Kaligineedi <pkaligineedi@...gle.com>,
        Shailend Chand
	<shailend@...gle.com>,
        Andrew Lunn <andrew+netdev@...n.ch>,
        James Smart
	<james.smart@...adcom.com>,
        Dick Kennedy <dick.kennedy@...adcom.com>,
        "James
 E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
        "Martin K. Petersen"
	<martin.petersen@...cle.com>,
        Roger Pau Monné
	<roger.pau@...rix.com>,
        Jens Axboe <axboe@...nel.dk>, Kalle Valo
	<kvalo@...nel.org>,
        Jeff Johnson <jjohnson@...nel.org>,
        Catalin Marinas
	<catalin.marinas@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jack
 Wang <jinpu.wang@...ud.ionos.com>,
        Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz
	<luiz.dentz@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Florian Fainelli <florian.fainelli@...adcom.com>,
        Ray Jui
	<rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>,
        Broadcom internal
 kernel review list <bcm-kernel-feedback-list@...adcom.com>,
        Xiubo Li
	<xiubli@...hat.com>, Ilya Dryomov <idryomov@...il.com>,
        Josh Poimboeuf
	<jpoimboe@...nel.org>, Jiri Kosina <jikos@...nel.org>,
        Miroslav Benes
	<mbenes@...e.cz>, Petr Mladek <pmladek@...e.com>,
        Joe Lawrence
	<joe.lawrence@...hat.com>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai
	<tiwai@...e.com>,
        Lucas Stach <l.stach@...gutronix.de>,
        Russell King
	<linux+etnaviv@...linux.org.uk>,
        Christian Gmeiner
	<christian.gmeiner@...il.com>,
        Louis Peens <louis.peens@...igine.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Nicholas Piggin <npiggin@...il.com>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Naveen N Rao
	<naveen@...nel.org>,
        Madhavan Srinivasan <maddy@...ux.ibm.com>
CC: <netfilter-devel@...r.kernel.org>, <coreteam@...filter.org>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <cocci@...ia.fr>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-s390@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <intel-xe@...ts.freedesktop.org>, <linux-scsi@...r.kernel.org>,
        <xen-devel@...ts.xenproject.org>, <linux-block@...r.kernel.org>,
        <linux-wireless@...r.kernel.org>, <ath11k@...ts.infradead.org>,
        <linux-mm@...ck.org>, <linux-bluetooth@...r.kernel.org>,
        <linux-staging@...ts.linux.dev>,
        <linux-rpi-kernel@...ts.infradead.org>, <ceph-devel@...r.kernel.org>,
        <live-patching@...r.kernel.org>, <linux-sound@...r.kernel.org>,
        <etnaviv@...ts.freedesktop.org>, <oss-drivers@...igine.com>,
        <linuxppc-dev@...ts.ozlabs.org>,
        Anna-Maria Behnsen
	<anna-maria@...utronix.de>,
        Michael Kelley <mhklinux@...look.com>,
        Thomas
 Gleixner <tglx@...utronix.de>,
        Luiz Augusto von Dentz
	<luiz.von.dentz@...el.com>
Subject: Re: [PATCH 22/22] jiffies: Define secs_to_jiffies()

On 11/15/2024 1:22 PM, Easwar Hariharan wrote:
> secs_to_jiffies() is defined in hci_event.c and cannot be reused by
> other call sites. Hoist it into the core code to allow conversion of the
> ~1150 usages of msecs_to_jiffies() that either:
> 
>  - use a multiplier value of 1000 or equivalently MSEC_PER_SEC, or
>  - have timeouts that are denominated in seconds (i.e. end in 000)
> 
> It's implemented as a macro to allow usage in static initializers.
> 
> This will also allow conversion of yet more sites that use (sec * HZ)
> directly, and improve their readability.
> 
> Suggested-by: Michael Kelley <mhklinux@...look.com>
> Signed-off-by: Easwar Hariharan <eahariha@...ux.microsoft.com>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Reviewed-by: Luiz Augusto von Dentz <luiz.von.dentz@...el.com>
> Link: https://lore.kernel.org/all/20241030-open-coded-timeouts-v3-1-9ba123facf88@linux.microsoft.com

your signed-off-by should be last.

and you have a patch ordering problem since this patch must come before all
the patches that use secs_to_jiffies(), otherwise this series cannot be bisected

Powered by blists - more mailing lists