netdev - RE: [PATCH v2 4/4] hyperv: Switch from hyperv-tlfs.h to hyperv/hvhdk.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SN6PR02MB4157DE83D677F2E463774393D4242@SN6PR02MB4157.namprd02.prod.outlook.com>
Date: Fri, 15 Nov 2024 21:54:14 +0000
From: Michael Kelley <mhklinux@...look.com>
To: Nuno Das Neves <nunodasneves@...ux.microsoft.com>,
	"linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"iommu@...ts.linux.dev" <iommu@...ts.linux.dev>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-pci@...r.kernel.org"
	<linux-pci@...r.kernel.org>, "linux-arch@...r.kernel.org"
	<linux-arch@...r.kernel.org>, "virtualization@...ts.linux.dev"
	<virtualization@...ts.linux.dev>
CC: "kys@...rosoft.com" <kys@...rosoft.com>, "haiyangz@...rosoft.com"
	<haiyangz@...rosoft.com>, "wei.liu@...nel.org" <wei.liu@...nel.org>,
	"decui@...rosoft.com" <decui@...rosoft.com>, "catalin.marinas@....com"
	<catalin.marinas@....com>, "will@...nel.org" <will@...nel.org>,
	"luto@...nel.org" <luto@...nel.org>, "tglx@...utronix.de"
	<tglx@...utronix.de>, "mingo@...hat.com" <mingo@...hat.com>, "bp@...en8.de"
	<bp@...en8.de>, "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
	"x86@...nel.org" <x86@...nel.org>, "hpa@...or.com" <hpa@...or.com>,
	"seanjc@...gle.com" <seanjc@...gle.com>, "pbonzini@...hat.com"
	<pbonzini@...hat.com>, "peterz@...radead.org" <peterz@...radead.org>,
	"daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>, "joro@...tes.org"
	<joro@...tes.org>, "robin.murphy@....com" <robin.murphy@....com>,
	"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "lpieralisi@...nel.org"
	<lpieralisi@...nel.org>, "kw@...ux.com" <kw@...ux.com>, "robh@...nel.org"
	<robh@...nel.org>, "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
	"arnd@...db.de" <arnd@...db.de>, "sgarzare@...hat.com" <sgarzare@...hat.com>,
	"jinankjain@...ux.microsoft.com" <jinankjain@...ux.microsoft.com>,
	"muminulrussell@...il.com" <muminulrussell@...il.com>,
	"skinsburskii@...ux.microsoft.com" <skinsburskii@...ux.microsoft.com>,
	"mukeshrathor@...rosoft.com" <mukeshrathor@...rosoft.com>,
	"vkuznets@...hat.com" <vkuznets@...hat.com>, "ssengar@...ux.microsoft.com"
	<ssengar@...ux.microsoft.com>, "apais@...ux.microsoft.com"
	<apais@...ux.microsoft.com>
Subject: RE: [PATCH v2 4/4] hyperv: Switch from hyperv-tlfs.h to
 hyperv/hvhdk.h

From: Nuno Das Neves <nunodasneves@...ux.microsoft.com> Sent: Friday, November 15, 2024 1:15 PM
> 
> On 11/10/2024 8:13 PM, Michael Kelley wrote:
> > From: Nuno Das Neves <nunodasneves@...ux.microsoft.com> Sent: Thursday, November 7, 2024 2:32 PM
> >>
> >> Switch to using hvhdk.h everywhere in the kernel. This header includes
> >> all the new Hyper-V headers in include/hyperv, which form a superset of
> >> the definitions found in hyperv-tlfs.h.
> >>
> >> This makes it easier to add new Hyper-V interfaces without being
> >> restricted to those in the TLFS doc (reflected in hyperv-tlfs.h).
> >>
> >> To be more consistent with the original Hyper-V code, the names of some
> >> definitions are changed slightly. Update those where needed.
> >>
> >> hyperv-tlfs.h is no longer included anywhere - hvhdk.h can serve
> >> the same role, but with an easier path for adding new definitions.
> >
> > Is hyperv-tlfs.h and friends being deleted? If not, the risk is that
> > someone adds a new #include of it without realizing that it has been
> > superseded by hvhdk.h.
> >
> 
> I was hesitant to delete it because I thought someone may still have
> a use for a header file that (mostly) reflects the TLFS document and
> nothing more.
> 
> But in practical terms, this patchset makes it much more difficult to
> use because all the helper code (i.e. mshyperv.h) now uses hvhdk.h.
> So, maybe there is no point keeping it.
> 
> > Note also that this patch does not apply cleanly to 6.12 rc's, or to
> > current linux-next trees. There's an unrelated #include added to
> > arch/x86/include/asm/kvm_host.h that causes a merge failure
> > in that file.
> >
> 
> I've been developing this series based on hyperv-next. Should I be
> basing it on linux-next?
> 

Yes, base it on linux-next. hyperv-next was last sync'ed with
upstream at 6.11-rc4 back in mid-August, so it's pretty far
out-of-date. Wei will need to sync it before picking up any
new patches.

Michael