netdev - Re: [PATCH net-next v2 7/8] ethtool: remove the comments that are not gonna be generated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZzfDIjiVxUbHsIUg@mini-arch>
Date: Fri, 15 Nov 2024 13:54:42 -0800
From: Stanislav Fomichev <stfomichev@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Stanislav Fomichev <sdf@...ichev.me>, netdev@...r.kernel.org,
	davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	donald.hunter@...il.com, horms@...nel.org, corbet@....net,
	andrew+netdev@...n.ch, kory.maincent@...tlin.com
Subject: Re: [PATCH net-next v2 7/8] ethtool: remove the comments that are
 not gonna be generated

On 11/15, Jakub Kicinski wrote:
> On Fri, 15 Nov 2024 11:36:45 -0800 Stanislav Fomichev wrote:
> > -/* MAC Merge (802.3) */
> > -
> >  enum {
> >  	ETHTOOL_A_MM_STAT_UNSPEC,
> >  	ETHTOOL_A_MM_STAT_PAD,
> > +	ETHTOOL_A_MM_STAT_REASSEMBLY_ERRORS,
> > +	ETHTOOL_A_MM_STAT_SMD_ERRORS,
> > +	ETHTOOL_A_MM_STAT_REASSEMBLY_OK,
> > +	ETHTOOL_A_MM_STAT_RX_FRAG_COUNT,
> > +	ETHTOOL_A_MM_STAT_TX_FRAG_COUNT,
> > +	ETHTOOL_A_MM_STAT_HOLD_COUNT,
> >  
> > -	/* aMACMergeFrameAssErrorCount */
> > -	ETHTOOL_A_MM_STAT_REASSEMBLY_ERRORS,	/* u64 */
> > -	/* aMACMergeFrameSmdErrorCount */
> > -	ETHTOOL_A_MM_STAT_SMD_ERRORS,		/* u64 */
> > -	/* aMACMergeFrameAssOkCount */
> > -	ETHTOOL_A_MM_STAT_REASSEMBLY_OK,	/* u64 */
> > -	/* aMACMergeFragCountRx */
> > -	ETHTOOL_A_MM_STAT_RX_FRAG_COUNT,	/* u64 */
> > -	/* aMACMergeFragCountTx */
> > -	ETHTOOL_A_MM_STAT_TX_FRAG_COUNT,	/* u64 */
> > -	/* aMACMergeHoldCount */
> > -	ETHTOOL_A_MM_STAT_HOLD_COUNT,		/* u64 */
> 
> These comments could be useful to cross reference with the IEEE spec.
> Can we add them as doc: ?

Absolutely, I did port these (and the rest of the comments that I removed)
over as doc: (see patch 4).